Is C&P&M really that hard ?
On 06.07.2015 22:45, Bastian Sieker wrote:
Ok,
I will take care of it and let you know when there is mentionable progress.
Basti
Am 06/07/15 um 18:28 schrieb Zieris, Franz:
Alright, so here are the problems one by one:
1. Method ui.model.Account.getBareJid() actually returns the raw JID (incl.
the resource part)
2. Our hourly build does not run the same tests as our per-patch-set Gerrit
builds.
In particular, we do have an array of Saros-Gerrit-QA-X jobs (X being "Core", "Eclipse",
"Whiteboard", and "IntelliJ").
But since we introduced even more sub-projects in the past, we need jobs for X being
"UI" and "UI.frontend" as well.
3. There is no how-to yet for creating such jobs.
Problem no. 2 is also the reason why Matthias' patch [1] is on hold:
The newly created test cases are not executed by Jenkins (@Matthias: that's why
Stefan linked to the full console output).
To solve these problems:
1. I just provided a patch [2].
Please note: Jenkins' "Verified" is misleading here.
No test cases were executed, including the one that failed on the master
branch (see below).
That's why we need to solve no. 2 first.
2. @Basti: If I remember correctly, you already started working on
Saros-Gerrit-QA-UI.frontend didn't you?
So either you use the knowledge you build up during this to create
Saros-Gerrit-QA-UI as well;
or you confide in Matthias to do so.
Please decide yourself (no dpp-devel discussion needed), and after
successfully creating these two new jobs ...
3. ... please jot down a short how-to here [3].
Thanks,
Franz
[1] http://saros-build.imp.fu-berlin.de/gerrit/2749
[2] http://saros-build.imp.fu-berlin.de/gerrit/2757
[3] http://www.saros-project.org/ci-rules
-----Original Message-----
From: Stefan Rossbach [mailto:srossb...@arcor.de]
Sent: Monday, July 06, 2015 5:28 PM
To: Zieris, Franz; dpp-devel@lists.sourceforge.net
Subject: Re: [DPP-Devel] Jenkins build became unstable: Saros #1444
I did not correct this as I only had written the test case. See:
http://saros-build.imp.fu-berlin.de/gerrit/#/c/2756/
Unfortunately I refuse to setup another SQ job (for the Gerrit build
itself) as there is no documentation on how to setup such a job.
So in the end:
Gerrit CI Jobs does not run any test cases (even if you execute them the
result will be ignored) but the Saros Build does.
Maybe you can ask the original author if he/she really think that a bare
JID should include the resource part.
I do not think so.
On 06.07.2015 17:21, Zieris, Franz wrote:
The console output says
test:
[mkdir] Created dir:
/var/lib/jenkins/jobs/Saros/workspace/de.fu_berlin.inf.dpp.ui/report/junit
[junit] Running de.fu_berlin.inf.dpp.ui.model.AccountTest
[junit] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed:
0.154 sec
[junit] Test de.fu_berlin.inf.dpp.ui.model.AccountTest FAILED
And the test case itself:
Error Message
expected:<al...@example.org[]> but was:<al...@example.org[/test]>
Stacktrace
junit.framework.AssertionFailedError: expected:<al...@example.org[]> but
was:<al...@example.org[/test]>
at
de.fu_berlin.inf.dpp.ui.model.AccountTest.testGetters(AccountTest.java:16)
I don't know where the actual problem is (production code or test code), but
this became visible with one of the recent commits.
Is anyone on this yet?
Reminder (as this rarely happens): Our rules state, that "Any commit that breaks the
CI will be reverted." [1]
Franz
[1] http://www.saros-project.org/review
-----Original Message-----
From: jenk...@saros-build.imp.fu-berlin.de
[mailto:jenk...@saros-build.imp.fu-berlin.de]
Sent: Monday, July 06, 2015 3:27 PM
To: dpp-devel@lists.sourceforge.net
Subject: [DPP-Devel] Jenkins build became unstable: Saros #1444
See <http://saros-build.imp.fu-berlin.de/jenkins/job/Saros/1444/changes>
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel
------------------------------------------------------------------------------
Don't Limit Your Business. Reach for the Cloud.
GigeNET's Cloud Solutions provide you with the tools and support that
you need to offload your IT needs and focus on growing your business.
Configured For All Businesses. Start Your Cloud Today.
https://www.gigenetcloud.com/
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel