Hi, After the move of ChangeColorManager to the core is merged, the only remaining non-core dependency of SarosSession will be SharedResourcesManager. This dependency seems to simply be a hack: SarosSession calls a projectAdded() method of SharedResourcesManager in addProjectMapping(), and projectRemoved() on removeProjectMapping(). (A comment says "// HACK", but doesn't go into any details.)
Glorifying this hack by making it an interface in order to move SarosSession to the core feels dirty. How about adding projectAdded() and projectRemoved() methods to ISessionListener (ISharedProjectListener in master) instead? SharedResourcesManager could listen for these events and SarosSession wouldn't have to know anything about SharedResourcesManager's existence anymore - it would just have to fire the events instead. Any objections? Regards, Denis ------------------------------------------------------------------------------ _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
