Hi Mehmet, > We have checked in our solution with gerrit.
Nope, you didn't. There is no patch bearing your name in our system [1]. So: - Make sure you push your commit to Gerrit [2,3] - Then you can invite developers to review your patch directly through Gerrit's web interface. - Only if you don't know who to invite, you may write an e-mail on the mailing list. But don't forget to include the URL of your patch; it looks like this "http://saros-build.imp.fu-berlin.de/gerrit/#/c/2925/"; Cheers, Franz [1] http://saros-build.imp.fu-berlin.de/gerrit/#/q/owner:Mehmet [2] http://www.saros-project.org/commit-and-push-first-change [3] http://saros-build.imp.fu-berlin.de/gerrit/Documentation/user-upload.html#push_create -----Original Message----- From: Mehmet Bayram [mailto:mehmetbay...@zedat.fu-berlin.de] Sent: Wednesday, November 18, 2015 12:52 PM To: dpp-devel@lists.sourceforge.net Subject: [DPP-Devel] Bug 857 fixed Hello, we have fixed a bug: Bug number: 857 (HTML) Description: Add Contact which is already available leads to rename We have solved the problem by checking in the addContact() method whether the roster already contains this contact. If so, it throws a ContactExistsAlreadyException and if not it adds the contact to the roster. The thrown exception is catched in ContactSpecificBrowserFunctions.java where the JavaScript call for adding is forwarding to StateFacade.addContact(). In the catch clause a prompt is triggered: browser.run("SarosApi.trigger('showError', '" + ... + "')"); We have checked in our solution with gerrit. Best regards, Ahmet-Serdar Karakaya Mehmet Bayram ------------------------------------------------------------------------------ _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel ------------------------------------------------------------------------------ _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
