We are now leaving the Saros-specific zone.
Please refer to the official documentation of the tools you're using (Git, 
Gerrit, probably some Git client).

Here are a few hints:
Gerrit only show this error message if you tried to push a commit without a 
change-id.

The most likely reason for the behavior you observed is that you tried to push 
more than one commit,
and not all of them contained a change-id. In particular, your local history 
might look like this:

 * abcdef1 [FIX] #857 (HEAD -> master)
 * abcdef2 tmp
 * abddef3 first try
 | * f2afba3 [FIX][I] Change Modality type of Wizards (origin/master)
 |/
 * fad7dc5 [NOP] Delete outdated patch file from Whiteboard

Even if "abdef1" looks fine to you (with correct commit message and everything),
you will run into the error message if "abcdef2" and "abcdef3" do not contain a 
change-id.
Pushing that "[FIX] #857" commit to Gerrit would -- in the success scenario --
result in *three* patches. So you want your history to look more like this:

 * abcdef4 [FIX] #857 (HEAD -> master)
 | * f2afba3 [FIX][I] Change Modality type of Wizards (origin/master)
 |/
 * fad7dc5 [NOP] Delete outdated patch file from Whiteboard

Refer to the Git documentation or one of the several online tutorials on how to 
do this [1].

To inspect your local history in the first place, you can either use your 
command line,
creating an output like the example above:

 $> git log --graph --all --decorate --oneline

Leave out the "--oneline" to see the full commit message and to find the commit 
which does not
contain a change-id.
Alternatively, you can use EGit [1]. Make sure you have the following two 
toggle buttons enabled:
First, the yellow "repository" [2]; second, the blue split arrow [3].

Franz

[1] https://www.atlassian.com/git/tutorials/rewriting-history/git-rebase-i 
[2] 
http://help.eclipse.org/juno/topic/org.eclipse.egit.doc/help/EGit/User_Guide/Reference.html?cp=20_0_3_1_2#History_View
[3] 
http://help.eclipse.org/juno/topic/org.eclipse.egit.doc/help/EGit/User_Guide/Reference.html?cp=20_0_3_1_2_4_1#Filter_settings
[4] 
http://help.eclipse.org/juno/topic/org.eclipse.egit.doc/help/EGit/User_Guide/Reference.html?cp=20_0_3_1_2_4_3#All_Branches
 


-----Original Message-----
From: Mehmet Bayram [mailto:mehmetbay...@zedat.fu-berlin.de] 
Sent: Wednesday, November 18, 2015 3:02 PM
To: dpp-devel@lists.sourceforge.net
Subject: [DPP-Devel] Gerrit Problem: missing Change-Id in commit message footer

Hello,

We try to push our changes according to [1]. But we can't pass step 9 (Push 
Result). There is an error in the bottom field which says:



Repository ssh://mehmet.bay...@saros-build.imp.fu-berlin.de:29418/saros.git

missing Change-Id in commit message footer Processing changes: (\) Processing 
changes: (|) Processing changes: (/) Processing changes: refs: 1 (/) Processing 
changes: refs: 1, done
ERROR: missing Change-Id in commit message footer

Hint: To automatically insert Change-Id, install the hook:
  gitdir=$(git rev-parse --git-dir); scp -p -P 29418 
mehmet.bay...@saros-build.imp.fu-berlin.de:hooks/commit-msg
${gitdir}/hooks/
And then amend the commit:
  git commit --amend


But there was a Change-Id like it is shown in step 3 (Writing a commit
message) of [1].
Again, any help would be much appreciated.


Best Regards,
Ahmet-Serdar Karakaya
Mehmet Bayram

[1] http://www.saros-project.org/commit-and-push-first-change


------------------------------------------------------------------------------
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel

------------------------------------------------------------------------------
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel

Reply via email to