Hello Saros Team, We are studying Softwareprozess with Professor Prechelt and Franz Zieris. As a part of our practical course exercises, we should participate and contribute to an Open Source Software team. Our group consists of me and Murat Uzun and we are happy to be able to contribute to the Saros Project. We would like to invite you to help us with code review and suggestions.
We decided by the BUG 837 <https://sourceforge.net/p/dpp/bugs/837/> and we have forwarded a patch on: <http://saros-build.imp.fu-berlin.de/gerrit/#/c/2954/> The problem occurs when the source project name contained a trailing number, for example ALP4. The code suggested a project name without trailing number. In this case, there was no comparison with the actual project name. A surplus allocation in line 637 of EnterProjectNamePage function caused the code to do the comparison name without the last number. In addition, we suggests a change to the index began to be counted from 1. We do questions on Sourceforge, where Franz and Stefan helped us. They suggested us also adopt a new content rating to the proposed names. Thus, the left number that defines the index should be separated by a "_" as in the following example. Previous: ALP -> ALP1 New: ALP -> ALP_1 They also told us to use the TDD in the process. Just when we we implemented it, then we could send the Patch through Gerrit. We did and sent the contribution. We have the contribution of Stefan, who refractored the code, significantly reducing the number of lines of the function. He also rewrote the test cases so as to be more readable and straightforward. We thank you in advance, especially Franz Stephan and that has helped us. -- Elias da Cunha Alves Bachelor Informatik - UFVJM/Diamantina, MG - Brasilien Stipendiat (CAPES-CsF/) Freie Universität Berlin Skype|Linkedin|Google+: unixelias ------------------------------------------------------------------------------ _______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
