Hello everyone, I’d like to propose a change to our initialization and destruction of Pico containers. As you might know we have so called SarosContextFactories which define the classes to be loaded.
So far we have the following Saros*ContextFactories: Core, Eclipse, IntelliJ and HTMLUI. And these are instantiated in multiple setup methods. Even though the implementations differ (see Before.png attachment) they share the same idea: set up the CoreContextFactory plus some additional platform specific factories. I think this code could be moved to the core. There could be abstract class called “SarosAbstractLifecycle” or something which is a singleton that handles the factory setups. Then there are classes like “SarosEclipseLifecycle” that inherit the abstract class and adds the Eclipse and HTMLUI factories. Take a look at attachment After.png as a draft. I’d seperate the plugin logic from the Saros Context setup since they are identical across platforms. What do you think about this change? I think it would increase the quality of our code if we extract this code into a core class. Also I need a better name for that. SarosLifecycle? SarosContextManager? I don’t know. Regards, David S.
smime.p7s
Description: S/MIME cryptographic signature
------------------------------------------------------------------------------ Go from Idea to Many App Stores Faster with Intel(R) XDK Give your users amazing mobile app experiences with Intel(R) XDK. Use one codebase in this all-in-one HTML5 development environment. Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs. http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________ DPP-Devel mailing list DPP-Devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/dpp-devel
