> The method is called if there is an error In saros/I

That’s crucial information as they are two DialogUtils classes.

The documentation [1] says:

Each of these methods also comes in a showInternalXXX flavor,
which uses an internal frame to hold the dialog box (see 
JInternalFrame<https://docs.oracle.com/javase/6/docs/api/javax/swing/JInternalFrame.html>).

The linked tutorials [2,3] say:

You should consider carefully whether to base your program's GUI around
frames or internal frames. Switching from internal frames to frames or vice
versa is not necessarily a simple task. By experimenting with both frames and
internal frames, you can get an idea of the tradeoffs involved in choosing
one over the other.

Here is a picture of an application that has two internal frames (one of which
is iconified) inside a regular frame:

[InternalFrameDemo has multiple internal frames, managed by a desktop pane]
I really don’t think anyone wanted an internal frame for anything in the Swing 
GUI of Saros/I,
simply because the optics didn’t matter: There just needed to be some GUI.

Franz


[1] https://docs.oracle.com/javase/6/docs/api/javax/swing/JOptionPane.html
[2] http://docs.oracle.com/javase/tutorial/uiswing/components/dialog.html
[3] http://docs.oracle.com/javase/tutorial/uiswing/components/internalframe.html

From: Michaela Borzechowski [mailto:michabo...@googlemail.com]
Sent: Tuesday, September 13, 2016 3:17 PM
To: dpp-devel@lists.sourceforge.net
Subject: [DPP-Devel] DialogUtils Show Error

Hi everyone,
I was wondering whether it has a reason that in DialogUtils.showError it says 
JOptionPane.showInternalMessageDialog, where it says 
JOptionPane.showMessageDialog in all the other methods.

The method is called if there is an error In saros/I, for example when the 
sessionNegotiation fails, which then displays an error message box. So far so 
good. The box has several problems though:
- it is too small (only the standard window buttons) and in the upper left 
corner, very easy to miss that it is there
- If you click ok, the text disapeares, but the box doesn't close
- if you hit the X, nothing happenes, so you can't close the dialog box at all.
If you change showInternalMessageDialog to showMessageDialog it works fine.
So is the "Internal" just an accident or does it have a special purpose?
Regards
Michaela
------------------------------------------------------------------------------
_______________________________________________
DPP-Devel mailing list
DPP-Devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-devel

Reply via email to