This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The saros eclipse plugin.".
The branch, master has been updated
via 3ac82f6e2332a62adf05e56df461b185dfae0442 (commit)
from 379d7991de8ddf7e85fedca51326ab9b5b204151 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3ac82f6e2332a62adf05e56df461b185dfae0442
Author: Holger Hans Peter Freyther <hol...@freyther.de>
Date: Sat May 19 10:36:04 2012 +0200
[FIX] NPE in the IncomingProjectNegotiation
The InviteAndLeaveStressTest triggers the NPE found below. Avoid
calling the ISarosSessionManager.getSarosSession() method as the
session could have been terminated already. Modify the code to
work directly on the ISarosSession and avoid this class of problems
completely. Modify the SarosSessionManager to not implement the
ISarosSessionListener interface, remove the listener parameter
from the negotiator. This required me to add the relevant methods
to the ISarosSessionManager interface.
java.lang.NullPointerException
at
de.fu_berlin.inf.dpp.invitation.IncomingProjectNegotiation.executeCancellation(IncomingProjectNegotiation.java:567)
at
de.fu_berlin.inf.dpp.invitation.IncomingProjectNegotiation.processException(IncomingProjectNegotiation.java:553)
at
de.fu_berlin.inf.dpp.invitation.IncomingProjectNegotiation.accept(IncomingProjectNegotiation.java:217)
at
de.fu_berlin.inf.dpp.ui.wizards.AddProjectToSessionWizard$2.run(AddProjectToSessionWizard.java:260)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Change-Id: I191cb759844d64f607339728121e063546b634aa
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/93
Tested-by: Jenkins CI
Reviewed-by: Norman Warnatsch <nor...@warnatsch.name>
Reviewed-by: Maria Spiering <maria.spier...@fu-berlin.de>
Reviewed-by: Holger Freyther <hol...@freyther.de>
-----------------------------------------------------------------------
Summary of changes:
.../dpp/invitation/IncomingProjectNegotiation.java | 39 +++++++++-----------
.../dpp/invitation/IncomingSessionNegotiation.java | 15 +++-----
.../dpp/invitation/OutgoingSessionNegotiation.java | 11 ++----
.../fu_berlin/inf/dpp/project/ISarosSession.java | 4 ++
.../inf/dpp/project/ISarosSessionManager.java | 30 +++++++++++++++
.../inf/dpp/project/SarosSessionManager.java | 25 ++++++-------
.../inf/dpp/serviceProviders/NullSarosSession.java | 6 +++
.../inf/dpp/test/stubs/SarosSessionStub.java | 5 +++
8 files changed, 81 insertions(+), 54 deletions(-)
hooks/post-receive
--
The saros eclipse plugin.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dpp-robot mailing list
Dpp-robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
