Bugs item #3118933, was opened at 2010-11-25 15:44 Message generated for change (Settings changed) made by kargor You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3118933&group_id=167540
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Synchronisation / Invitation Group: None Status: Open Resolution: None Priority: 8 Private: No Submitted By: nudelfish (nudelfish) >Assigned to: Nobody/Anonymous (nobody) Summary: Host delete shared project Initial Comment: Host and peers are still in session after host delete the shared project To reproduce this bug: Pre condition: alice(host) bob(invitee) 1. alice share a project P with bob 2. alice delete the project P 3. alice and bob don't leave the session. ---------------------------------------------------------------------- Comment By: A. Haferburg (ahaferburg) Date: 2010-12-09 02:10 Message: In rev 2810 there is now a warning message when trying to delete the project. Still open: Should the session be closed automatically? If we stay in the session, and e.g. the host deletes a project, there is no more consistency recovery for that project, and other parts of Saros might stop working, too. If there are other shared projects, I believe the best thing to do would be to "unshare" the deleted project, i.e. remove it from the session. That's something for Christian's thesis. So I think for now it would probably be best to always leave the session. As the host that means that the session gets terminated. ---------------------------------------------------------------------- Comment By: A. Haferburg (ahaferburg) Date: 2010-11-26 06:54 Message: I'll have a look, I'm kinda familiar with that part of the code. I believe we currently simply ignore this case in the code. If the project doesn't exist anymore, we don't send any activities, which means the peers won't notice anything from the deletion. We could try to prevent it, but what if the user didn't delete the project from within Eclipse, but e.g. in Windows Explorer, then did a refresh in Eclipse? Or if another plugin deletes the project? We can't prevent that, but how do we handle it? Leaving the session seems like the easiest way out, except maybe if there are other shared projects in the session. We still shouldn't have the peers copies deleted. ---------------------------------------------------------------------- Comment By: Karl Beecher (k_beecher) Date: 2010-11-26 06:29 Message: As implied in the message, I don't think deleting a project should end a session. This will be especially true in future when we support multiple shared projects per session. But your point is still important. Deleting a whole project shouldn't really be allowed during a session (also deleting a peer's copy of the project accidentally is too big a risk). I propose that we should intercept delete actions, then test if the resource to be deleted is a shared project. If so, we should throw an error message to the user saying they must leave the session before deleting a shared project. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3118933&group_id=167540 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Dpp-robot mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dpp-robot
