Bugs item #3540379, was opened at 2012-07-05 00:00
Message generated for change (Comment added) made by kargor
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3540379&group_id=167540

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Synchronisation / Invitation
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Sebastian Starroske (starroli)
Assigned to: Sebastian Starroske (starroli)
Summary: Rework the method projectNameIsUnique(..) 

Initial Comment:
The method EnterPageNameUtils.projectNameIsUnique(..)  is used at different 
places with different intentions:
1) test if the given name is included in a list of reserved project names
2) test if a project already exists in the current workspace
3) test if file with the given name exists in the current directory of the 
workspace

Intention 2) is not implemented correctly:
The Eclipse API should be used to determine, if a project exists already in the 
workspace. Projects which are not physically located in the workspace are not 
included in the check.

Intention 3) is implemented to uses Java.IO.File to check this. Maybe ther is a 
way to do this using the eclipse API


----------------------------------------------------------------------

>Comment By: Stefan Rossbach (kargor)
Date: 2012-07-05 17:03

Message:
Analyse issue 3. I think this requirement is not needed,

so the code is


Set<IProject> currentProjects = new HashSet<IProject>

currentProjects.addAll(Arrays.asList(ResourcePlugin.getWorkspace().getRoot().getProjects())

for (String reservedProject : reservedProjects)
 
currentProjects.add(ResourcePlugin.getWorkspace().getRoot().getProject(reseverdProject)

return ! currentProjects.contains(newProject)


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3540379&group_id=167540

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot

Reply via email to