Bugs item #3539670, was opened at 2012-07-03 03:18 Message generated for change (Comment added) made by franzzieris You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3539670&group_id=167540
Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Synchronisation / Invitation Group: 12.7.6.TESTING >Status: Pending >Resolution: Fixed Priority: 8 Private: No Submitted By: Franz Zieris (franzzieris) Assigned to: Franz Zieris (franzzieris) Summary: Cancellation of initial invitation does not quit the session Initial Comment: Session with ALICE and BOB. ALICE has a large project (at least 10 MB in order to make the cancellation feasible). * ALICE starts the invitation. BOB gets an invitation. * BOB accepts the invitation and chooses target project name. * ALICE and BOB are in a session. The project transmission starts. * ALICE cancels the transmission. * After ALICE's cancellation both users still are in a running session -- the ending of the session and a notification would be the expected result. On ALICE's side the project is marked as "shared"; on BOB's side it's "partial shared", containing only the empty project folder. Priority 8 because: * Has to be fixed in the next release. * The scenario worked in previous releases, and we don't want to release regressions. ---------------------------------------------------------------------- >Comment By: Franz Zieris (franzzieris) Date: 2012-07-06 06:20 Message: Fix was cherry-picked in release/12.7.6 as 7addcdb. ---------------------------------------------------------------------- Comment By: Franz Zieris (franzzieris) Date: 2012-07-05 05:03 Message: The review for the fix of this: http://saros-build.imp.fu-berlin.de/gerrit/134 To make it clear: this is not a duplicate of #3458957. This bug is about the unintended deactivation of the automatic stopping the of session after a "Cancel". ---------------------------------------------------------------------- Comment By: Franz Zieris (franzzieris) Date: 2012-07-04 02:23 Message: In general you're right. But in 12.3.30 the above scenario worked out and #3458957 was never closed. And: In this scenario BOB has only the project folder, not "folders". Is this really a duplicate? ---------------------------------------------------------------------- Comment By: Alexander Waldmann (netcorps) Date: 2012-07-04 02:11 Message: Duplicate to 3458957 Please review the existing bugs before resubmitting an issue. Increase the priority of that issue instead. https://sourceforge.net/tracker/?func=detail&aid=3458957&group_id=167540&atid=843359 ---------------------------------------------------------------------- Comment By: Stefan Rossbach (kargor) Date: 2012-07-03 07:49 Message: http://dpp.git.sourceforge.net/git/gitweb.cgi?p=dpp/saros;a=commitdiff;h=3ac82f6e2332a62adf05e56df461b185dfae0442 @@ -612,11 +609,9 @@ public class IncomingProjectNegotiation extends ProjectNegotiation { cancellationCause); } - // The session might have been stopped already, if not we will stop it. - ISarosSession session = sessionManager.getSarosSession(); - if (session != null) { - if (session.getProjectResourcesMapping().keySet().isEmpty() - || session.getRemoteUsers().isEmpty()) + if (sarosSession.isStopped()) { + if (sarosSession.getProjectResourcesMapping().keySet().isEmpty() + || sarosSession.getRemoteUsers().isEmpty()) sessionManager.stopSarosSession(); } should be: if (!sarosSession.isStopped()) ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3539670&group_id=167540 ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Dpp-robot mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/dpp-robot
