Bugs item #3577466, was opened at 2012-10-15 15:18
Message generated for change (Settings changed) made by kargor
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3577466&group_id=167540

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: XMPP
Group: None
>Status: Closed
Resolution: Invalid
Priority: 5
Private: No
Submitted By: https://www.google.com/accounts ()
Assigned to: Nobody/Anonymous (nobody)
Summary: Add support for google apps accounts

Initial Comment:
As per a comment on issue 3133676, Saros does not work correctly with google 
apps accounts as it scrubs the domain from login name before authentication. 
There is code in Saros.java (Line 638) to check for google accounts. An 
additional check for server name should be added to flag talk.google.com as 
requiring the domain appended to the login name. Code should look like:

if (domain.equalsIgnoreCase("gmail.com")
            || domain.equalsIgnoreCase("googlemail.com")
            || server.equalsIgnoreCase("talk.google.com")) {
            username += "@" + domain;
        }

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-10-17 10:32

Message:
I'll subscribe to the list then, thanks.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-10-17 10:31

Message:
I took a look in the git repo, specifically
http://dpp.git.sourceforge.net/git/gitweb.cgi?p=dpp/saros;a=blob;f=de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/Saros.java;h=4507c2ac8a0816e05148eafdb3d37c41bbdcdcf1;hb=refs/heads/master#l636

Note that the domain is only appended to the login name if the user
specifies gmail.com or googlemail.com as their domain.

Google app accounts must also have their domain appended to the login name
sent to the xmpp server, or authentication does not succeed, hence my
adding a check for the server being set to talk.google.com as an additional
indicator that a google account is being used.

----------------------------------------------------------------------

Comment By: Franz Zieris (franzzieris)
Date: 2012-10-17 10:28

Message:
Please move this discussion and all its spin-offs to the mailing list
dpp-devel. Since you show certain interest in our development process, I'd
really appeciate your subscription
(https://lists.sourceforge.net/lists/listinfo/dpp-devel).

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-10-17 10:22

Message:
You may wish to update your dev guide, as there is still a reference to the
svn repository.

I originally encountered this issue in Saros 12.9.28 obtained via
http://dpp.sourceforge.net/update

----------------------------------------------------------------------

Comment By: Stefan Rossbach (kargor)
Date: 2012-10-16 15:58

Message:
The SVN Repo is out of date. Please use the GIT repo.

BTW, the server has nothing to do with the login name.

JID = [email protected]
Server: example.com

Login would be: Username: [email protected], Pw: *****, Server: example.com

PS: I always test stuff before I respond.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-10-16 14:27

Message:
I am changing the resolution back to none - take a good look at the code
and actually test it using a google apps account ([email protected]),
and you will see that this is a valid issue/bug/missing feature.

----------------------------------------------------------------------

Comment By: https://www.google.com/accounts ()
Date: 2012-10-16 14:14

Message:
Using Mint Linux and JDK6. This is with the latest code checked out from
https://dpp.svn.sourceforge.net/svnroot/dpp/trunk/dpp/de.fu_berlin.inf.dpp

----------------------------------------------------------------------

Comment By: Stefan Rossbach (kargor)
Date: 2012-10-15 17:05

Message:
If you are using an old Saros Version (pre 2012) and do not use Mac OS(if
you use MAC OS, try to install a Java 7 JVM from Oracle), just leave the
server field empty and all should work well.

----------------------------------------------------------------------

Comment By: Stefan Rossbach (kargor)
Date: 2012-10-15 16:47

Message:
Saros Version ?
Mac OS ?

Works fine on Windows (and should work for Mac). Tested with
talk.google.com
xmpp.l.google.com 

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=843359&aid=3577466&group_id=167540

------------------------------------------------------------------------------
LogMeIn Rescue: Anywhere, Anytime Remote support for IT. Free Trial
Remotely access PCs and mobile devices and provide instant support
Improve your efficiency, and focus on delivering more value-add services
Discover what IT Professionals Know. Rescue delivers
http://p.sf.net/sfu/logmein_12329d2d
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot

Reply via email to