This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via a5493f993bc2ce57461fcbcaa2e0818e38a47814 (commit)
from ee98169fe40d17ca05b09da5ca9ca662bad90b0f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit a5493f993bc2ce57461fcbcaa2e0818e38a47814
Author: Franz Zieris <[email protected]>
Date: Thu Jun 13 14:57:47 2013 +0200
[REFACTOR] Split methods in Outgoing/IncomingSessionNegotiation
In preparation for better "observability" of the whole invitation
process (as a precondition for better modularization), this patch splits
some methods on both sides of the SessionNegotiation.
One goal was to separate methods that actively perform a step and those
which only wait for changes on the other side.
Furthermore, some methods were renamed to highlight there actual purpose
(e.g. "awaitRemoteSessionNegotiationData" -->
"awaitClientSessionPreferences", or "modifySessionNegotiationData" -->
"determineSessionParameters").
Finally, instead of "peers" these two classes now speak of "client" and
"host" where applicable.
As a minor addition, the methods create/deleteCollectors were grouped,
and the overriding methods were moved to the top of the classes.
Change-Id: Ifd39c4e8cd7546417c69d3ea87b8fa3e33c4085c
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/826
Tested-by: Jenkins CI
Reviewed-by: Patrick Schlott <[email protected]>
Reviewed-by: Stefan Rossbach <[email protected]>
Reviewed-by: Franz Zieris <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../dpp/invitation/IncomingSessionNegotiation.java | 182 ++++++++++++--------
.../dpp/invitation/OutgoingSessionNegotiation.java | 167 ++++++++++--------
2 files changed, 203 insertions(+), 146 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
