This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via c78a857e9dc416c95e5c15222e654f45fe717389 (commit)
from b83cb8975a46f704bfba92dbe265ca3ab64dd0be (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit c78a857e9dc416c95e5c15222e654f45fe717389
Author: Franz Zieris <[email protected]>
Date: Mon Jun 17 13:15:11 2013 +0200
[REFACTOR] Move automatic invitation ACK to InvitationHandler
The "one-line-method" for automatically acknowledging the host's
invitation upon reception was (mis)placed inside the
IncomingSessionNegotiation. Now, the ACK is placed in the same method
that automatically rejects the invitation in case the invited user
already participates in another session.
Methods that prepare the Negotiation (i.e. by ruling out special cases
beforehand) should not be placed inside the Negotation itself. That way
the code gets more comprehensible.
The JTourBusTour "Invitation Process" was amended accordingly (e.g. by
an additional Stop).
Change-Id: Ib006ffe320c5af207050457086071dce75593abb
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/828
Reviewed-by: Stefan Rossbach <[email protected]>
Tested-by: Jenkins CI
-----------------------------------------------------------------------
Summary of changes:
.../dpp/invitation/IncomingSessionNegotiation.java | 29 +++-----------------
.../dpp/invitation/OutgoingSessionNegotiation.java | 8 +++++
.../inf/dpp/net/business/InvitationHandler.java | 26 ++++++++++++++---
.../dpp/ui/eventhandler/NegotiationHandler.java | 13 +++++++--
4 files changed, 43 insertions(+), 33 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
