This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 98a8e89009b0c6d37fd17ee925b3c720b2c2a0d0 (commit)
from bdfd147623210174cf656687fd7a5ce42cf54a76 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 98a8e89009b0c6d37fd17ee925b3c720b2c2a0d0
Author: Franz Zieris <[email protected]>
Date: Mon Jul 29 20:57:03 2013 +0200
[INTERNAL] Reworked standard methods of classes in activities.*
Quite a number of hashCode(), equals(), and toString() implementations
in the activities.* package were written in a cumbersome way. The new
implementations of these methods:
- make use of org.apache.commons.lang.ObjectUtils.equals() and
.hashCode()
- perform the necessary checks ordered by increasing "costs" (first
primitives and Enums, then other objects)
- allow subclassing (some equals() implementations required the *same*
class instead of using "instanceof")
- follow a common structure (much easier to read, e.g. for new
developers)
However, this patches does not introduce new standard methods: If a
class was lacking them before, this patch does not add them.
Furthermore, some ActivityDataObjects were not as "dumb" as they are
supposed to be. Instead they duplicated some logic from their Activity
counterparts (i.e. they checked the parameters passed to their
constructors). These duplications were removed.
Also all @Nullable annotations were removed (they were stemming from
PicoContainer and were of no use in this package). Instead, all
constructor parameters that might be null were accordingly described in
their JavaDoc.
Finally, a bunch of test cases was added to ensure the proper conversion
from IActivity -> IActivityDataObject -> IActivity. The three year old
(!) problem that was fixed in 449b5576774e315dbc6564ed80ceb376b0bd56d7
would have been detected by this.
Remark: This patch is likely to break the compatibility with older Saros
versions because the name of a field in StopActivityDataObject changed.
Change-Id: I40baa09a2e387f4b3e9bccc0b9e54778e7f07bd5
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/862
Reviewed-by: Arsenij Solovjev <[email protected]>
Tested-by: Jenkins CI
Reviewed-by: Patrick Schlott <[email protected]>
Reviewed-by: Franz Zieris <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
de.fu_berlin.inf.dpp/build.xml | 1 +
.../inf/dpp/activities/ProjectExchangeInfo.java | 1 +
.../activities/ProjectExchangeInfoDataObject.java | 1 +
.../src/de/fu_berlin/inf/dpp/activities/SPath.java | 40 ++---
.../inf/dpp/activities/SPathDataObject.java | 43 ++---
.../dpp/activities/business/AbstractActivity.java | 9 +-
.../activities/business/ChangeColorActivity.java | 13 +-
.../dpp/activities/business/ChecksumActivity.java | 40 +++--
.../activities/business/ChecksumErrorActivity.java | 60 ++++---
.../dpp/activities/business/EditorActivity.java | 34 ++--
.../inf/dpp/activities/business/FileActivity.java | 54 +++---
.../dpp/activities/business/FolderActivity.java | 26 ++--
.../dpp/activities/business/JupiterActivity.java | 47 ++---
.../inf/dpp/activities/business/NOPActivity.java | 7 +-
.../activities/business/PermissionActivity.java | 31 ++--
.../dpp/activities/business/ProgressActivity.java | 54 +++---
.../activities/business/RecoveryFileActivity.java | 9 +-
.../business/StartFollowingActivity.java | 9 +-
.../inf/dpp/activities/business/StopActivity.java | 95 +++++-----
.../activities/business/StopFollowingActivity.java | 8 +-
.../dpp/activities/business/TextEditActivity.java | 32 ++--
.../activities/business/TextSelectionActivity.java | 30 ++--
.../inf/dpp/activities/business/VCSActivity.java | 136 ++++++++++-----
.../dpp/activities/business/ViewportActivity.java | 27 ++--
.../serializable/AbstractActivityDataObject.java | 9 +-
.../AbstractProjectActivityDataObject.java | 31 ++++
.../ChangeColorActivityDataObject.java | 8 +-
.../serializable/ChecksumActivityDataObject.java | 45 +++---
.../ChecksumErrorActivityDataObject.java | 14 +-
.../serializable/EditorActivityDataObject.java | 38 ++---
.../serializable/FileActivityDataObject.java | 57 ++-----
.../serializable/FolderActivityDataObject.java | 35 ++--
.../serializable/IActivityDataObject.java | 2 +
.../serializable/JupiterActivityDataObject.java | 52 ++----
.../serializable/NOPActivityDataObject.java | 1 +
.../serializable/PermissionActivityDataObject.java | 29 ++--
.../serializable/ProgressActivityDataObject.java | 20 +--
.../RecoveryFileActivityDataObject.java | 26 ++-
.../StartFollowingActivityDataObject.java | 17 +-
.../serializable/StopActivityDataObject.java | 65 +++-----
.../StopFollowingActivityDataObject.java | 15 +--
.../TextSelectionActivityDataObject.java | 28 ++--
.../serializable/VCSActivityDataObject.java | 12 +-
.../serializable/ViewportActivityDataObject.java | 27 ++--
.../de/fu_berlin/inf/dpp/editor/EditorManager.java | 6 +-
.../fu_berlin/inf/dpp/synchronize/StopManager.java | 2 +-
.../junit/de/fu_berlin/inf/dpp/AllTestSuite.java | 6 +-
.../inf/dpp/activities/ActivityTestSuite.java | 36 ++++
.../activities/business/AbstractActivityTest.java | 186 ++++++++++++++++++++
.../business/AbstractResourceActivityTest.java | 35 ++++
.../business/ChangeColorActivityTest.java | 52 ++++++
.../activities/business/ChecksumActivityTest.java | 42 +++++
.../business/ChecksumErrorActivityTest.java | 46 +++++
.../activities/business/EditorActivityTest.java | 29 +++
.../dpp/activities/business/FileActivityTest.java | 55 ++++++
.../activities/business/FolderActivityTest.java | 30 +++
.../activities/business/JupiterActivityTest.java | 46 +++++
.../dpp/activities/business/NOPActivityTest.java | 27 +++
.../business/PermissionActivityTest.java | 31 ++++
.../activities/business/ProgressActivityTest.java | 45 +++++
.../business/RecoveryFileActivityTest.java | 143 ++++++---------
.../business/StartFollowingActivityTest.java | 23 +++
.../dpp/activities/business/StopActivityTest.java | 60 +++++++
.../business/StopFollowingActivityTest.java | 15 ++
.../business/TextSelectionActivityTest.java | 31 ++++
.../dpp/activities/business/VCSActivityTest.java | 33 ++++
.../activities/business/ViewportActivityTest.java | 28 +++
.../project/ResourceActivityFilterPluginTest.java | 4 +-
.../inf/dpp/synchronize/StopManagerTest.java | 8 +-
.../fu_berlin/inf/dpp/test/mocks/SarosMocks.java | 120 +++++++++++++
.../inf/dpp/vcs/VCSActivityPluginTest.java | 16 +-
71 files changed, 1726 insertions(+), 767 deletions(-)
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/ActivityTestSuite.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/AbstractActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/AbstractResourceActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/ChangeColorActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/ChecksumActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/ChecksumErrorActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/EditorActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/FileActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/FolderActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/JupiterActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/NOPActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/PermissionActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/ProgressActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/StartFollowingActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/StopActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/StopFollowingActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/TextSelectionActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/VCSActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/activities/business/ViewportActivityTest.java
create mode 100644
de.fu_berlin.inf.dpp/test/junit/de/fu_berlin/inf/dpp/test/mocks/SarosMocks.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Get your SQL database under version control now!
Version control is standard for application code, but databases havent
caught up. So what steps can you take to put your SQL databases under
version control? Why should you start doing it? Read more to find out.
http://pubads.g.doubleclick.net/gampad/clk?id=49501711&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
