This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 7f95f21778defe8417e5672fbe2386bc184b4d69 (commit)
from f6b46f2d4497e37b50e3a5ad5d87d0bcd09ec2d0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7f95f21778defe8417e5672fbe2386bc184b4d69
Author: Conrad LäÃig <[email protected]>
Date: Fri Aug 23 16:06:59 2013 +0200
[NOP] Remove unused methods in EditorManager
Removed unused methods getLastEditTime() and getLastRemoteEditTime()
from EditorManager, because they aren't used anywhere anymore.
Furthermore FindBugs identified a possible bug, where an IPath was
expected, but SPath was used as key in a HashMap.
Brief history:
- The methods were added in commit 75c0264 (2008-12-16) and called from
the ConcurrentDocumentManager. Back then, inconsistencies were detected
after waiting at least five (or two) seconds after the last local (or
remote) edit.
- getLastRemoteEditTime() was shortly used in XMPPChatTransmitter from
75c0264 (2008-12-16) to a455685 (2008-12-17).
- In e1a73e7 (2009-04-14) the Watchdog was transferred to
ConsistencyWatchdogClient and with it the methods.
- In 2ac5726 (2009-09-24) the method calls disappeared. From there on
inconsistencies were detected by using the Jupiter timestamp.
Furthermore the HashMaps lastEditTimes and lastRemoteEditTimes were
removed, because they were merely Write-Only-Memory structures: only
written and cleared, but never read.
Moral of the story: Better comments for the mentioned methods describing
their *purpose* (e.g. "helping the watchdog doing his job") would have
prevented them from staying here so long unused.
Copied from SWTP-2013 repository.
- Commit: 9477036078290699301260b50cb3e35843d8a99b
- Reviewed on: http://saros-build.imp.fu-berlin.de/gerrit/874
- Reviewed by: Richard Möhn <[email protected]>
- Reviewed by: Christoph Krüger <[email protected]>
Change-Id: I70bdd8a805f50f6fac163739f94f4e5f195e3c0b
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/883
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../de/fu_berlin/inf/dpp/editor/EditorManager.java | 50 --------------------
.../de/fu_berlin/inf/dpp/editor/EditorPool.java | 4 --
2 files changed, 0 insertions(+), 54 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Introducing Performance Central, a new site from SourceForge and
AppDynamics. Performance Central is your source for news, insights,
analysis and resources for efficient Application Performance Management.
Visit us today!
http://pubads.g.doubleclick.net/gampad/clk?id=48897511&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
