This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 1c94156fe92620d0d188edecb7e96093edcee788 (commit)
from 07d265f29f5af0fce046763078f2b7e58c6d19b9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 1c94156fe92620d0d188edecb7e96093edcee788
Author: Stefan Rossbach <[email protected]>
Date: Thu Nov 7 20:05:08 2013 +0100
[INTERNAL] ensure the SelectionService will not throw NPE
Depending on the current thread the selection service will not be
available. As this service is almost only used in the actions you can
find a very ugly pattern that was C&P throughout all actions.
try
{
Selection* = Selection*.get*
}
catch(NullPointerException)
The NPE was caused due an invalid thread access because not ALL !
listeners from the Saros Logic are invoked in the SWT Thread context.
TODO: Refactor all actions but note: even in the SWT Thread context the
selection service might be not available e.g the workbench is shutting
down.
Also removed a marker interface as it was never queried and thus not
needed at all.
REFACTOR: replaced generic type identifiers with T and S to be conform
with the Java coding conventions regarding generic type name parameter
naming.
Change-Id: I736d078e9e7c0320708491d190474d54fce0963f
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1216
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../inf/dpp/ui/util/selection/SelectionUtils.java | 63 ++++++++++++++-----
.../retriever/ISelectionConvertingRetriever.java | 20 ------
.../selection/retriever/ISelectionRetriever.java | 35 ++++++-----
.../retriever/SelectionRetrieverFactory.java | 20 +++---
.../impl/AbstractSelectionConvertingRetriever.java | 35 +++++------
.../retriever/impl/SelectionRetriever.java | 41 +++++--------
6 files changed, 107 insertions(+), 107 deletions(-)
delete mode 100644
de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/util/selection/retriever/ISelectionConvertingRetriever.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
November Webinars for C, C++, Fortran Developers
Accelerate application performance with scalable programming models. Explore
techniques for threading, error checking, porting, and tuning. Get the most
from the latest Intel processors and coprocessors. See abstracts and register
http://pubads.g.doubleclick.net/gampad/clk?id=60136231&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
