This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 54ff066fc1a5e718fda76f84fb6812943d841360 (commit)
from c6ed74dd7788366e9dfedafaca59b4b6a3b7471d (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 54ff066fc1a5e718fda76f84fb6812943d841360
Author: Stefan Rossbach <[email protected]>
Date: Wed Nov 13 20:19:05 2013 +0100
[FIX] ensure Actions are disposed
It is up to Eclipse to decide whether to hide or to dispose a view part.
In an old stage of Saros Actions were handled by the Pico container.
Somehow the developer who actually changes the behavior forget to ensure
that those actions must now be *disposed* because they are now
may be created more than once during the plugin life time.
Change-Id: Ibb1031cd4292c925fef13db25db629b1fa1351bd
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1224
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
de.fu_berlin.inf.dpp/.classpath | 2 +-
.../inf/dpp/ui/actions/ChangeColorAction.java | 1 -
.../inf/dpp/ui/actions/DeleteContactAction.java | 1 -
.../fu_berlin/inf/dpp/ui/actions/Disposable.java | 14 ++
.../inf/dpp/ui/actions/FollowModeAction.java | 1 -
.../inf/dpp/ui/actions/FollowThisPersonAction.java | 1 -
.../inf/dpp/ui/actions/GiveWriteAccessAction.java | 1 -
.../JumpToUserWithWriteAccessPositionAction.java | 1 -
.../inf/dpp/ui/actions/OpenChatAction.java | 7 +-
.../ui/actions/RestrictToReadOnlyAccessAction.java | 3 +-
.../inf/dpp/ui/actions/SendFileAction.java | 1 -
.../fu_berlin/inf/dpp/ui/actions/SkypeAction.java | 5 +-
.../inf/dpp/ui/actions/StoppedAction.java | 1 -
.../inf/dpp/ui/actions/VideoSharingAction.java | 1 -
.../de/fu_berlin/inf/dpp/ui/views/SarosView.java | 139 +++++++++++++-------
15 files changed, 111 insertions(+), 68 deletions(-)
create mode 100644
de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/ui/actions/Disposable.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
