This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 36b49c5de05d51517f2c75225d439bdef2bc7bda (commit)
from b87c437b447a093254cb34231c15135888fac659 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 36b49c5de05d51517f2c75225d439bdef2bc7bda
Author: Stefan Rossbach <[email protected]>
Date: Sun Dec 1 07:33:38 2013 +0100
[INTERNAL|REFACTOR] removed preferences from UPNPService
They were mainly used to remove previous port mappings.
Problem: The right way to remove those mappings is to query
the IGD for all port forwardings and then delete those that match.
As it is very uncommon that.
1. Eclipse crashes
2. A user or SMACK will change ports after the crash
3. The port mapping is still overwritten if it was created by Saros
It is removed and will be replaced later with the recommendation above
REFACTOR: moved most parts from the UPNPService to SarosNet because the
UPNPService should handle the port mapping and should not start to
retrieve the port from the Socks5 server.
Change-Id: I103298ee8d0b2fb3ca6a858f5002dd1e2e91f469
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1249
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../src/de/fu_berlin/inf/dpp/Saros.java | 38 +-
.../fu_berlin/inf/dpp/SarosCoreContextFactory.java | 3 +
.../src/de/fu_berlin/inf/dpp/net/SarosNet.java | 341 ++++++----
.../inf/dpp/net/internal/DataTransferManager.java | 9 -
.../fu_berlin/inf/dpp/net/upnp/IUPnPService.java | 126 ++--
.../inf/dpp/net/upnp/internal/UPnPServiceImpl.java | 745 ++++++++------------
.../inf/dpp/net/util/NetworkingUtils.java | 36 +-
.../de/fu_berlin/inf/dpp/ui/messages.properties | 2 +-
.../ui/preferencePages/NetworkPreferencePage.java | 76 +--
.../inf/dpp/ui/wizards/ConfigurationWizard.java | 7 +-
.../pages/ConfigurationSettingsWizardPage.java | 7 +-
.../junit/de/fu_berlin/inf/dpp/net/UPnPTest.java | 67 +--
.../dpp/net/internal/DataTransferManagerTest.java | 32 +-
13 files changed, 674 insertions(+), 815 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
