This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via fd4072c1cbc1ddfa8c285c90fccc5f5dfb1da3bc (commit)
from 28a9bf95359551b68e32bd54898f9103c9daacc9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit fd4072c1cbc1ddfa8c285c90fccc5f5dfb1da3bc
Author: Stefan Rossbach <[email protected]>
Date: Sun Dec 8 01:48:33 2013 +0100
[REFACTOR] moved static utility method
This method offered so MUCH utility that it was "ONLY" used in one
place.
I am getting sick of this utility overload ... time to put out -2 on
Gerrit for senseless utility class stuff.
Last but not least I love this article
http://misko.hevery.com/2008/07/24/how-to-write-3v1l-untestable-code/
which nicely describes the issues if such "utility" methods do much more
than they are intended to do ! Again PowerMock is NOT the answer ... it
is not THE golden hammer against poor code design !!!
Change-Id: I1dc8493937dfe10f4b9290d704624270e92d8a95
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1273
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../inf/dpp/net/internal/Socks5Transport.java | 31 +++++++++++++-------
.../src/de/fu_berlin/inf/dpp/util/Utils.java | 17 -----------
2 files changed, 20 insertions(+), 28 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Sponsored by Intel(R) XDK
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
