This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 3f867381ce8521060957c975d0d71a5d6926543b (commit)
from 64a0cd9e75342dcbbec926724dd2eb289772169c (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 3f867381ce8521060957c975d0d71a5d6926543b
Author: Franz Zieris <[email protected]>
Date: Fri Dec 13 18:38:50 2013 +0100
[REFACTOR] Cleaned up annotation-related code in "editor" package
There is a new class "LocationAnnotationManager" which handles all
annotations that represent information about other users' whereabouts
(selection, text cursor position, viewport).
Methods in EditorManager and EditorAPI were renamed to represent their
actual jobs.
Additionally fixes an unknown (?) bug that existed prior to this patch:
When a user switched his active editor, the ViewportAnnotations of *all*
users were deleted (only occurred in 3+ user sessions, of course).
Main parts of this patch was already reviewed on
http://saros-build.imp.fu-berlin.de/gerrit/1233, and submitted as
45f73983116f6461ccecc6d20c41998d3fea165e. But since Stefan discovered a
performance issue I reverted it. This patch now includes the necessary
changes to get a similar performance as without this refactoring.
Change-Id: I5ea4898e0b41ccbbfb780b621eb10b4405bde753
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1295
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <[email protected]>
Reviewed-by: Arndt Lasarzik <[email protected]>
Reviewed-by: Nils Bussas <[email protected]>
Reviewed-by: Franz Zieris <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../de/fu_berlin/inf/dpp/editor/EditorManager.java | 162 +++++-------
.../dpp/editor/internal/AnnotationModelHelper.java | 118 ++++++++
.../inf/dpp/editor/internal/EditorAPI.java | 202 +--------------
.../inf/dpp/editor/internal/IEditorAPI.java | 21 --
.../editor/internal/LocationAnnotationManager.java | 284 ++++++++++++++++++++
5 files changed, 467 insertions(+), 320 deletions(-)
create mode 100644
de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/internal/AnnotationModelHelper.java
create mode 100644
de.fu_berlin.inf.dpp/src/de/fu_berlin/inf/dpp/editor/internal/LocationAnnotationManager.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT
organizations don't have a clear picture of how application performance
affects their revenue. With AppDynamics, you get 100% visibility into your
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
