This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 2d4391cedf39d525abce05f830bd02aee9c121f2 (commit)
from a8cedaa16cba495ae2da0dd97f9bf07215c6cdd9 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2d4391cedf39d525abce05f830bd02aee9c121f2
Author: Franz Zieris <[email protected]>
Date: Wed Apr 9 13:10:37 2014 +0200
[FIX] Path-based editor closing was not working
The convenience methods EditorManager.isOpenEditor() and .closeEditor()
were not working because for finding the correct editor, they relied on
the equality of Eclipse's IResource and Saros Core's IResource (which is
always false).
This led to no compilation errors, because the equals() method is
declared on Object and takes any Object as parameter.
However, this defect did not lead to failures because (1) these methods
are only executed during inconsistency recovery which is seldom
necessary, and (2) even then, closing the affected editors does not seem
required to resolve the inconsistencies.
Change-Id: I56ce64f3b756146fd54dbc495042f07da855d743
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1497
Tested-by: Jenkins CI
Reviewed-by: Franz Zieris <[email protected]>
-----------------------------------------------------------------------
Summary of changes:
.../de/fu_berlin/inf/dpp/editor/EditorManager.java | 48 +++++++------------
.../inf/dpp/editor/internal/IEditorAPI.java | 7 ++-
.../inf/dpp/project/SharedResourcesManager.java | 15 +++----
3 files changed, 28 insertions(+), 42 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
http://p.sf.net/sfu/NeoTech
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
