This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via d7ffc46023ab156d81445c005be3ccccb6d62377 (commit)
from e3e1528b34a186f2deced557650bf5913783e9d1 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d7ffc46023ab156d81445c005be3ccccb6d62377
Author: Stefan Rossbach <[email protected]>
Date: Thu Jun 12 20:09:04 2014 +0200
[INTERNAL] fix for commit 7e5faaa6a1e9816e548f6c52b81823c69f5d403d
Lessons learned.
1. Do not ignore CI STF regression failures
2. static variables can be evil
3. Eclipse may dispose the view at any time
What actually happened:
Due to the change, the Write and Read permission actions were only
created once. When the view was disposed, the dispose methods were run.
When the view was recreated those disposed and no more functional
actions were put into the context menu.
Change-Id: Ib7052a2994b1c8f779c6c45151cc33e7f05379a2
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/1669
Reviewed-by: Stefan Rossbach <[email protected]>
Tested-by: Jenkins CI
-----------------------------------------------------------------------
Summary of changes:
.../dpp/ui/actions/ChangeWriteAccessAction.java | 46 ++++++++++++-------
.../de/fu_berlin/inf/dpp/ui/views/SarosView.java | 20 ++++++---
2 files changed, 42 insertions(+), 24 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions
Find What Matters Most in Your Big Data with HPCC Systems
Open Source. Fast. Scalable. Simple. Ideal for Dirty Data.
Leverages Graph Analysis for Fast Processing & Easy Data Exploration
http://p.sf.net/sfu/hpccsystems
_______________________________________________
Dpp-robot mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/dpp-robot
