This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via b25ca6b7367f9d2422f5f2bd34d2210c8bffd1a7 (commit)
from d5f1f1f794c5cc67f7078edfa552bc80b23ebf07 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit b25ca6b7367f9d2422f5f2bd34d2210c8bffd1a7
Author: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
Date: Sun Jul 19 17:06:51 2015 +0200
[Internal][HTML] Rework BrowserFunctions
This commit changes the whole BrowserFunctions (BFs from now on)creation
and seperation.
Previously the BFs were bundled for each BrowserPage usage. As a
single BF, like for example GetValidJID, can be used in many different
BrowserPages this bundling isn't reasonable anymore.
Instead of prebundling and wiring the BFs to single BrowserPages, each
BF is now created in a dedicated class inside the browser_functions
package. These classes have JDoc for better explanation of the purpose
and the JavaScript signature, which improves the usage of the previously
anonymous BF a lot. A HTML UI developer now has a place to look up the
name and semantic of injected JavaScript without searching big bundle
classes for the actual naming and implementation.
These BrowserFunctions and BrowserPages are injected
field-injection. The BrowserPages and HTMLUIContext are changed
accordingly to this.
While reworking the BrowserFunctions this commit also adds a lot of
TODOs which should be done in later patches.
Change-Id: I37bb9bcfe686b5890354af51d3511dce729dbec0
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2777
Tested-by: Jenkins CI
Reviewed-by: Bastian Sieker <bsie...@mail.uni-paderborn.de>
Reviewed-by: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
-----------------------------------------------------------------------
Summary of changes:
.../de/fu_berlin/inf/dpp/HTMLUIContextFactory.java | 64 ++++++--
.../src/de/fu_berlin/inf/dpp/HTMLUIStrings.java | 2 +
.../AddAccountBrowserFunctions.java | 133 -----------------
.../inf/dpp/ui/browser_functions/AddContact.java | 40 +++++
.../ui/browser_functions/CloseAccountWizard.java | 28 ++++
.../CloseSessionInvitationWizard.java | 28 ++++
.../dpp/ui/browser_functions/ConnectAccount.java | 50 +++++++
.../ContactSpecificBrowserFunctions.java | 112 --------------
.../dpp/ui/browser_functions/DeleteContact.java | 40 +++++
.../ui/browser_functions/DisconnectAccount.java | 35 +++++
.../inf/dpp/ui/browser_functions/GetValidJID.java | 39 +++++
.../MainPageBrowserFunctions.java | 123 ----------------
.../inf/dpp/ui/browser_functions/NameCreator.java | 25 +++
.../dpp/ui/browser_functions/RenameContact.java | 44 ++++++
.../inf/dpp/ui/browser_functions/SaveAccount.java | 62 ++++++++
.../dpp/ui/browser_functions/SendInvitation.java | 113 ++++++++++++++
.../SessionWizardPageBrowserFunctions.java | 155 --------------------
.../dpp/ui/browser_functions/ShowAccountPage.java | 30 ++++
.../ui/browser_functions/ShowSessionWizard.java | 34 +++++
.../fu_berlin/inf/dpp/ui/webpages/AccountPage.java | 57 +++++++
.../inf/dpp/ui/webpages/AddAccountPage.java | 47 ------
.../fu_berlin/inf/dpp/ui/webpages/BrowserPage.java | 44 +++---
.../de/fu_berlin/inf/dpp/ui/webpages/MainPage.java | 90 +++++++-----
.../inf/dpp/ui/webpages/SessionWizardPage.java | 39 ++++--
24 files changed, 781 insertions(+), 653 deletions(-)
delete mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/AddAccountBrowserFunctions.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/AddContact.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/CloseAccountWizard.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/CloseSessionInvitationWizard.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/ConnectAccount.java
delete mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/ContactSpecificBrowserFunctions.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/DeleteContact.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/DisconnectAccount.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/GetValidJID.java
delete mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/MainPageBrowserFunctions.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/NameCreator.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/RenameContact.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/SaveAccount.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/SendInvitation.java
delete mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/SessionWizardPageBrowserFunctions.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/ShowAccountPage.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/browser_functions/ShowSessionWizard.java
create mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/webpages/AccountPage.java
delete mode 100644
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/webpages/AddAccountPage.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
_______________________________________________
DPP-Robot mailing list
DPP-Robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
