This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 795042f69e7222ec6ebc2e7b39cc9b071a835d71 (commit)
from 462cafe97a0408da9102418240a45efff42d7f56 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 795042f69e7222ec6ebc2e7b39cc9b071a835d71
Author: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
Date: Thu Nov 12 11:40:47 2015 +0100
[INTERNAL][HTML] Adds abstract BrowserPage to reduce code duplication
First this renames the interface BrowserPage to IBrowserPage in order to
follow our code convention. Furthermore all BrowserPages share the same
PATH="html/dist/", and have common implementation. This common behavior
is now encapsulated in the abstract BrowserPage. BrowserFunctions and
Renderer are now injected on instantiation of each Page using this super
class.Renderer and BrowserFunction are stored in a list instead of
recreating them on each call of "getJavascriptFunctions()".
This Change also include the adjustment of some naming for methods and
fields in the BrowserPages in order to better reflect their purpose.
WEB-PAGE is changed to HTML_DOC_NAME and getWebpage to
getWebpageResource.
Due to a circle reference between Page->ClosePageBrowserFunction->Page,
each pages still holds an public static field with their HTML_DOC_NAME.
This field is needed in the DialogManger in order to close them.
Change-Id: Ieea3013f68b31e7b3568c8a81fee6f40d8a5a3be
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2949
Tested-by: Jenkins CI
Reviewed-by: Franz Zieris <zie...@inf.fu-berlin.de>
-----------------------------------------------------------------------
Summary of changes:
.../ui/swt_browser/IntelliJDialogManager.java | 6 +-
.../intellij/ui/swt_browser/SwtBrowserCanvas.java | 6 +-
.../dpp/stf/server/rmi/htmlbot/HTMLBotImpl.java | 6 +-
.../inf/dpp/stf/server/rmi/htmlbot/IHTMLBot.java | 4 +-
.../rmi/remotebot/widget/impl/RemoteBotDialog.java | 6 +-
.../ui/browser_functions/CloseAccountWizard.java | 6 +-
.../CloseSessionInvitationWizard.java | 2 +-
.../inf/dpp/ui/ide_embedding/BrowserCreator.java | 8 +-
.../inf/dpp/ui/ide_embedding/DialogManager.java | 75 ++++++++-------
.../inf/dpp/ui/manager/BrowserManager.java | 14 ++--
.../fu_berlin/inf/dpp/ui/webpages/AccountPage.java | 42 ++-------
.../fu_berlin/inf/dpp/ui/webpages/BrowserPage.java | 99 +++++++++++---------
.../{BrowserPage.java => IBrowserPage.java} | 17 ++--
.../de/fu_berlin/inf/dpp/ui/webpages/MainPage.java | 47 ++--------
.../inf/dpp/ui/webpages/SessionWizardPage.java | 41 ++-------
.../inf/dpp/ui/browser/EclipseDialogManager.java | 6 +-
16 files changed, 160 insertions(+), 225 deletions(-)
copy
de.fu_berlin.inf.dpp.ui/src/de/fu_berlin/inf/dpp/ui/webpages/{BrowserPage.java
=> IBrowserPage.java} (80%)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app experiences with Intel(R) XDK.
Use one codebase in this all-in-one HTML5 development environment.
Design, debug & build mobile apps & 2D/3D high-impact games for multiple OSs.
http://pubads.g.doubleclick.net/gampad/clk?id=254741911&iu=/4140
_______________________________________________
DPP-Robot mailing list
DPP-Robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
