This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 4df141ebb2504162f4f472f30c3e3f56c1ef25a7 (commit)
from a45c25111c72b26a05a8aa4396b33c1db537ab48 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 4df141ebb2504162f4f472f30c3e3f56c1ef25a7
Author: Denis Washington <de...@denisw.de>
Date: Tue Jul 21 09:35:42 2015 +0200
[INTERNAL] Remove "newSession" flag from JoinSessionRequestExtension
This flag controlled whether the sender wants the receiver to
create a new session or invite the sender to an existing one.
This design is problematic because the sender doesn't know if
the receiver has already started a session; guessing wrong
(sending newSession=true if the receiver has started a session
already or newSession=false if there is no session yet) inevitably
causes an error response.
To solve this problem, this commit removes the newSession flag and
instead adopts the following logic:
* If there is no session running on the receiver when receiving the
request, one is created.
* If there is a running session, the request's sender is invited to
the existing session instead.
Change-Id: I29d1c11d253cd330c426d76b5c104a07c9c8a270
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/2781
Tested-by: Jenkins CI
Reviewed-by: Denis Washington <de...@denisw.de>
-----------------------------------------------------------------------
Summary of changes:
.../extensions/JoinSessionRequestExtension.java | 10 ----------
.../ui/eventhandler/JoinSessionRequestHandler.java | 16 ++++++++++------
2 files changed, 10 insertions(+), 16 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________
DPP-Robot mailing list
DPP-Robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
