This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was dpp-gerrit.
The branch, master has been updated
via 09c874cce115aec8ecc89d49100e60c11a37afe5 (commit)
from 8bce6694b4ef26ffe283e2042fd070cfb0c4a6ef (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 09c874cce115aec8ecc89d49100e60c11a37afe5
Author: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
Date: Mon Apr 18 10:44:29 2016 +0200
[INTERNAL][HTML] Improve validation and log for contact operations
Problems in StateFacede:
The contact specific methods add- delete- and renameContact()
were failing silently without any logs. Furthermore
those guards were highly redundant and didn't deal with possible
invalide states if the connections is lost. This is now take care of by
extraction the guards in private methods, and throw exceptions on
failure.
Problems Browserfunctions:
didn't deal with null arguments for the JID which
could have lead to unhandled RuntimeException. Furthermore there where
no validation for these jids. This patch adds these checks, and the
validation.
Change-Id: Ic0f1de0cf9146e9cd340db44c6c81a195bb823bf
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/3058
Tested-by: Jenkins CI
Reviewed-by: David Sungaila <david.sunga...@arcor.de>
Reviewed-by: Nina Weber <nina.we...@fu-berlin.de>
Reviewed-by: Matthias Bohnstedt <matthias.bohnst...@gmail.com>
-----------------------------------------------------------------------
Summary of changes:
.../inf/dpp/ui/browser_functions/AddContact.java | 16 +++-
.../dpp/ui/browser_functions/DeleteContact.java | 7 ++
.../dpp/ui/browser_functions/RenameContact.java | 8 ++
.../dpp/ui/browser_functions/SendInvitation.java | 18 ++++-
.../inf/dpp/ui/core_facades/StateFacade.java | 94 +++++++++++---------
.../src/de/fu_berlin/inf/dpp/ui/model/Account.java | 11 ++-
6 files changed, 109 insertions(+), 45 deletions(-)
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
Attend Shape: An AT&T Tech Expo July 15-16. Meet us at AT&T Park in San
Francisco, CA to explore cutting-edge tech and listen to tech luminaries
present their vision of the future. This family event has something for
everyone, including kids. Get more information and register today.
http://sdm.link/attshape
_______________________________________________
DPP-Robot mailing list
DPP-Robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
