This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "The Saros Eclipse Plugin". Pusher was franzzieris.
The branch, master has been updated
via d2ebafdfdc2df1823d0c74682cd96b4cad28973d (commit)
from b28171fd5c9f10fd09ab6f62b34519eb17d8eb7f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit d2ebafdfdc2df1823d0c74682cd96b4cad28973d
Author: Franz Zieris <zie...@inf.fu-berlin.de>
Date: Wed Aug 31 20:15:53 2016 +0200
[API] Extract FollowModeManager from EditorManager
The EditorManager deals with many different responsibilities. This patch
extracts the FollowMode feature into a separate component. Since the
Saros/I EditorManager is very unclean, this patch mostly affects the
Saros/E side and does not yet extract the FollowMode in Saros/I.
The new FollowModeManager allows IFollowModeListener to hook in and get
notified about changes to the FollowMode status and the various reasons
it might get stopped automatically.
The FollowModeManager is session-scoped, as the feature only makes sense
when a Session is running.
There are many small task entangled with this larger task:
- Deprecate ISharedEditorListener.followModeChanged(), and use the new
IFollowModeListener instead.
- Pull up a few public "utility" methods from EditorManager to the
interface IEditorManager: openEditor(), closeEditor(),
adjustViewport(), and jumpToUser()
- Un-deprecation and type-safety for SarosSession.getComponent(). Being
constantly warned by the Java compiler does help in making sure the
references are properly reset to allow the GC to do its job.
Change-Id: I3181d8464e1b605a510d53d42ee3a958620dca70
Reviewed-on: http://saros-build.imp.fu-berlin.de/gerrit/3113
Tested-by: Jenkins CI
Reviewed-by: Stefan Rossbach <srossb...@arcor.de>
Reviewed-by: Franz Zieris <zie...@inf.fu-berlin.de>
-----------------------------------------------------------------------
Summary of changes:
.../dpp/editor/AbstractSharedEditorListener.java | 1 +
.../inf/dpp/editor/FollowModeManager.java | 322 +++++++++++++
.../fu_berlin/inf/dpp/editor/IEditorManager.java | 61 ++-
.../inf/dpp/editor/IFollowModeListener.java | 41 ++
.../inf/dpp/editor/ISharedEditorListener.java | 3 +
.../fu_berlin/inf/dpp/session/ISarosSession.java | 14 +-
.../session/SarosCoreSessionContextFactory.java | 2 +
.../inf/dpp/session/internal/SarosSession.java | 2 +-
.../inf/dpp/test/stubs/SarosSessionStub.java | 2 +-
.../inf/dpp/intellij/editor/EditorManager.java | 93 +++-
.../de/fu_berlin/inf/dpp/editor/EditorManager.java | 508 +++++++-------------
.../inf/dpp/feedback/FollowModeCollector.java | 31 +-
.../inf/dpp/feedback/SelectionCollector.java | 6 +
.../inf/dpp/project/SharedResourcesManager.java | 2 +-
.../internal/FollowingActivitiesManager.java | 34 +-
.../inf/dpp/ui/actions/ConsistencyAction.java | 4 +-
.../inf/dpp/ui/actions/FollowModeAction.java | 47 ++-
.../inf/dpp/ui/actions/FollowThisPersonAction.java | 41 +-
.../ui/model/session/SessionContentProvider.java | 44 ++-
.../inf/dpp/stf/server/StfRemoteObject.java | 14 +
.../component/view/saros/impl/SarosView.java | 12 +-
.../inf/dpp/feedback/StatisticCollectorTest.java | 13 +
.../inf/dpp/session/internal/SarosSessionTest.java | 7 +-
23 files changed, 842 insertions(+), 462 deletions(-)
create mode 100644
de.fu_berlin.inf.dpp.core/src/de/fu_berlin/inf/dpp/editor/FollowModeManager.java
create mode 100644
de.fu_berlin.inf.dpp.core/src/de/fu_berlin/inf/dpp/editor/IFollowModeListener.java
hooks/post-receive
--
The Saros Eclipse Plugin
------------------------------------------------------------------------------
_______________________________________________
DPP-Robot mailing list
DPP-Robot@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dpp-robot
