On Tue, Apr 6, 2010 at 4:58 PM, Ryan Davis <r...@acceleration.net> wrote:
> I think this justifies :KEEP-LAST as the default behavior, if you > interpret the first Set-Cookie header creating the cookie, and the > second Set-Cookie header superseding the pre-existing cookie. I agree. Maybe the documentation should mention the RFC. > I've attached a patch that introduces *remove-duplicate-cookies-p* as > you mentioned in earlier email, with NIL as the default, so existing > behavior is maintained. I haven't exported the symbol or added > documentation yet, but wanted to run this by you first. Looks good, thanks. > I wrote a few unit tests (using the LIFT framework, > http://common-lisp.net/project/lift/), are you interested in those? I'm > honestly not sure what value they will have to anyone else, and I'm > hesitant to add testing code to drakma proper if I'm the only one likely > to run it (and I'm fairly unlikely to run it after my itch is > scratched). If you'd like that, then I'll put together a separate patch > with a drakma-tests.asd to sort out the dependencies. I have plans to add a small test suite to Drakma, but I don't want to introduce a new dependency. For now, let's just leave it as it is. Thanks, Edi. _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
