Thanks. Generally, that looks fine to me except for a few stylistic changes I'd like to have. I think that what you have now (i.e. #1 from the three options) is the best way to integrate this with Drakma. I'm not too familiar with SOCKS5, so I'll have to trust you that this works and doesn't break anything else.
As for style issues, here are some: 1. The new package should be defined in packages.lisp. 2. All calls to error should use defined and exported conditions, either inherited from drakma-condition or from a new base class socks5-condition. 3. HTML documentation and integration with the system definition is missing from the diff. See also here: http://weitz.de/patches.html Thanks again, Edi. On Sun, Aug 8, 2010 at 1:09 AM, Red Daly <redd...@gmail.com> wrote: > Sure, > > http://github.com/gonzojive/drakma/commit/869007460ae2eb804bcd1600faacf9bda27e3709 > contains a diff. I also attached one. > > - Red > > On Sat, Aug 7, 2010 at 1:26 PM, Edi Weitz <e...@agharta.de> wrote: >> Hi Red, >> >> First of all, thanks for this, sounds good. Could you show us the >> diff somehow so that it's easier to see what exactly you've added and >> how? >> >> Edi. >> >> >> On Sat, Aug 7, 2010 at 1:29 AM, Red Daly <redd...@gmail.com> wrote: >>> I have modified Drakma to use a SOCKS5 proxy if desired. Before I >>> submit a patch I'd like to know what is the preferred interface for >>> this: >>> >>> 1. Modify http-request with a SOCKS-PROXY option analogous to the >>> PROXY option. Introduce SOCKS5 protocol code (about 200 lines) into >>> hunchentoot and rely on no external libraries >>> >>> 2. Modify http-request with a SOCKS-PROXY option analogous to the >>> PROXY option. Introduce a dependency on an external SOCKS5 library. >>> >>> 3. Modify Drakma in some way that allows a user to establish a >>> socks-proxy connection without explicitly supporting this in Drakma >>> itself. >>> >>> The implementation requires that instead of establishing a socket >>> connection to HOST/PORT, the socket connects to SOCKS-HOST/SOCKS-PORT >>> instead and then sets up the socket to forward to HOST/PORT. >>> >>> The implementation is available here: >>> http://github.com/gonzojive/drakma/tree/socks >>> >>> socks5 spec: http://www.faqs.org/rfcs/rfc1928.html >>> >>> Red >>> >>> _______________________________________________ >>> drakma-devel mailing list >>> drakma-devel@common-lisp.net >>> http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel >>> >> >> _______________________________________________ >> drakma-devel mailing list >> drakma-devel@common-lisp.net >> http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel >> > > _______________________________________________ > drakma-devel mailing list > drakma-devel@common-lisp.net > http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel > > _______________________________________________ drakma-devel mailing list drakma-devel@common-lisp.net http://common-lisp.net/cgi-bin/mailman/listinfo/drakma-devel
