On 01/03/2021 11.44, Lars Ellenberg wrote:
On Fri, Feb 26, 2021 at 07:09:29AM +0100, Fabio M. Di Nitto wrote:
hey guys,
similar to 9.0.27, log below.
Any chance you can give me a quick and dirty fix?
CC [M] /builddir/build/BUILD/drbd-9.0.28-1/drbd/drbd_main.o
/builddir/build/BUILD/drbd-9.0.28-1/drbd/drbd_main.c: In function
'drbd_create_device':
/builddir/build/BUILD/drbd-9.0.28-1/drbd/drbd_main.c:3729:6: error: implicit
declaration of function 'blk_alloc_queue'; did you mean
'blk_alloc_queue_rh'? [-Werror=implicit-function-declaration]
q = blk_alloc_queue(drbd_make_request, NUMA_NO_NODE);
^~~~~~~~~~~~~~~
blk_alloc_queue_rh
A short history of blk_alloc_queue():
[snip]
makes me happy I don´t do kernel development ;)
Our compat code detects this, by testing for ops->submit_bio,
and patches down from v5.8 style to v5.6 style,
then checks for (gfp_t) vs (fn, node_id) by checking for compile-time
availability of blk_queue_make_request(q,fn),
and would patches based on the above pattern [**].
But since it is NOT available, it does not.
But we do not yet detect this weird "changed sybol name for compat" thing.
Guess we need an extra test for "blk_alloc_queue_rh()",
and an extra compat patch :-(
Meanwhile, you can just add an extra sed statement.
Yeah I was hoping to do it right, cocci doesn´t seem a quick learning
curve ;)
Thanks
Fabio
_______________________________________________
Star us on GITHUB: https://github.com/LINBIT
drbd-user mailing list
[email protected]
https://lists.linbit.com/mailman/listinfo/drbd-user
