On Wed, Jun 23, 2010 at 07:03:01PM +0200, Dan Carpenter wrote:
> copy_to_user() returns the number of bytes remaining to be copied and
> I'm pretty sure we want to return a negative error code here.
> 

This patch wasn't applied either.

regards,
dan carpenter


> Signed-off-by: Dan Carpenter <erro...@gmail.com>
> 
> diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
> index 9ded3da..22691b4 100644
> --- a/drivers/gpu/drm/i915/i915_gem.c
> +++ b/drivers/gpu/drm/i915/i915_gem.c
> @@ -3707,6 +3707,7 @@ i915_gem_do_execbuffer(struct drm_device *dev, void 
> *data,
>               if (ret != 0) {
>                       DRM_ERROR("copy %d cliprects failed: %d\n",
>                                 args->num_cliprects, ret);
> +                     ret = -EFAULT;
>                       goto pre_mutex_err;
>               }
>       }
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to