On Fri, 6 Jun 2014 10:22:51 -0700 "Paul E. McKenney" <paulmck at linux.vnet.ibm.com> wrote:
> On Fri, Jun 06, 2014 at 03:56:52PM +0000, David Laight wrote: > > From: Behalf Of Ken Helias > > > All other add functions for lists have the new item as first argument and > > > the > > > position where it is added as second argument. This was changed for no > > > good > > > reason in this function and makes using it unnecessary confusing. > > > > > > Also the naming of the arguments in hlist_add_after was confusing. It was > > > changed to use the same names as hlist_add_after_rcu. > > ... > > > -static inline void hlist_add_after_rcu(struct hlist_node *prev, > > > - struct hlist_node *n) > > > +static inline void hlist_add_after_rcu(struct hlist_node *n, > > > + struct hlist_node *prev) > > > > It is rather a shame that the change doesn't generate a compilation > > error for old source files. > > I am also a bit concerned by this. > yup. hlist_add_behind()?
