Hi Matt,
Thank you for the patch.
On Thursday 27 March 2014 17:44:29 Matt Roper wrote:
> Ensure that existing driver loops over all planes do not change behavior
> when we begin adding new types of planes (primary and cursor) to the DRM
> plane list in future patches.
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas at ideasonboard.com>
> Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
I have a question though. The patch set introduces three plane types, OVERLAY,
PRIMARY and CURSOR. What should a driver that has no concept of primary plane
do ? Expose all planes as OVERLAY planes only ?
> ---
> drivers/gpu/drm/shmobile/shmob_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c index 0428076..ea543b4 100644
> --- a/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> +++ b/drivers/gpu/drm/shmobile/shmob_drm_crtc.c
> @@ -247,7 +247,7 @@ static void shmob_drm_crtc_start(struct shmob_drm_crtc
> *scrtc) lcdc_write(sdev, LDDDSR, value);
>
> /* Setup planes. */
> - list_for_each_entry(plane, &dev->mode_config.plane_list, head) {
> + drm_for_each_legacy_plane(plane, &dev->mode_config.plane_list) {
> if (plane->crtc == crtc)
> shmob_drm_plane_setup(plane);
> }
--
Regards,
Laurent Pinchart
