On Thu, May 22, 2014 at 4:02 AM, Thierry Reding <thierry.reding at gmail.com>wrote:
> On Tue, May 20, 2014 at 04:36:48PM -0700, St?phane Marchesin wrote: > > This panel is used by my tegra board and supported by the simple-panel > > driver. > > One thing I like to have is some indication in the commit message about > which board this panel is used on. Of course if you can't disclose that > yet I'll still take the patch, but perhaps you can be a little more > specific than "my Tegra board". > > There also seem to be different variants of this panel. I've come across > datasheets for B133XTN01.0 and B133XTN01.2. The 1.0 seems to be native > LVDS whereas it looks as if the 1.2 comes with an additional module to > connect it to eDP. Which one is it that you use? I guess independent of > the specific model the timings will still work, but device tree mandates > that the compatible for the most specific model be used. Perhaps this > panel should be: > > I'm using the B133XTN01.2. The panel specs are not exactly the same (the 1.2 has a single clock, 69.5MHz while the 1.0 does 60-80MHz), but the fixed timing that I put in the DT will work on both. St?phane > compatible = "auo,b133xtn01.2", "auo,b133xtn01", "simple-panel"; > > That would allow the panel-simple driver to match on "auo,b133xtn01" and > pick up the timing that presumably works for both. > > One other nit below: > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > [...] > > +static const struct panel_desc auo_b133xtn01 = { > > + .modes = &auo_b133xtn01_mode, > > + .num_modes = 1, > > + .size = { > > + .width = 293, > > + .height = 164, > > According to the datasheet I found this is 164.97 mm, in which case I > think it may be better to round up to get a more accurate value of the > DPI. > > Thierry > > _______________________________________________ > dri-devel mailing list > dri-devel at lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel > > -------------- next part -------------- An HTML attachment was scrubbed... URL: <http://lists.freedesktop.org/archives/dri-devel/attachments/20140523/0f552ed4/attachment-0001.html>