On pe, 2016-12-16 at 07:46 +0000, Chris Wilson wrote: > Check that after applying the driver's color adjustment, eviction > scanning find a suitable hole. > > Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
<SNIP> > +static int evict_color(struct drm_mm *mm, > + Â Â Â Â Â Â Â struct evict_node *nodes, > + Â Â Â Â Â Â Â unsigned int *order, > + Â Â Â Â Â Â Â unsigned int count, > + Â Â Â Â Â Â Â unsigned int size, > + Â Â Â Â Â Â Â unsigned int alignment, > + Â Â Â Â Â Â Â unsigned long color, > + Â Â Â Â Â Â Â const struct insert_mode *mode) expect_evict_color? evict_color gave me an impression of single-way action (when reading the next patch). Just a nitpick, so; Reviewed-by: Joonas Lahtinen <joonas.lahtinen at linux.intel.com> Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation
