Stephen Boyd <sboyd at codeaurora.org> writes:

> On 12/14, Eric Anholt wrote:
>>  
>>      /* the gates */
>>  
>> @@ -1890,8 +1976,18 @@ static int bcm2835_clk_probe(struct platform_device 
>> *pdev)
>>      if (IS_ERR(cprman->regs))
>>              return PTR_ERR(cprman->regs);
>>  
>> -    cprman->osc_name = of_clk_get_parent_name(dev->of_node, 0);
>> -    if (!cprman->osc_name)
>> +    for (i = 0; i < ARRAY_SIZE(cprman_parent_names); i++) {
>> +            cprman->real_parent_names[i] =
>> +                    of_clk_get_parent_name(dev->of_node, i);
>> +    }
>
> Can we use of_clk_parent_fill() here? Or do we need to support
> holes in the parent array? If it's the latter please add a
> comment so we don't mistakenly change this later.

It looks like that will work fine.  We'll only be missing parents from
the end of the array.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: 
<https://lists.freedesktop.org/archives/dri-devel/attachments/20161221/0343dbad/attachment.sig>

Reply via email to