On 09/19/16 16:33, ville.syrjala at linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala at linux.intel.com> > > drm/tilcdc/tilcdc_tfp410.c:385:24: warning: symbol 'tfp410_driver' was not > declared. Should it be static? > drm/tilcdc/tilcdc_tfp410.c:395:12: warning: symbol 'tilcdc_tfp410_init' was > not declared. Should it be static? > drm/tilcdc/tilcdc_tfp410.c:400:13: warning: symbol 'tilcdc_tfp410_fini' was > not declared. Should it be static? > drm/tilcdc/tilcdc_panel.c:436:24: warning: symbol 'panel_driver' was not > declared. Should it be static? > drm/tilcdc/tilcdc_panel.c:446:12: warning: symbol 'tilcdc_panel_init' was not > declared. Should it be static? > drm/tilcdc/tilcdc_panel.c:451:13: warning: symbol 'tilcdc_panel_fini' was not > declared. Should it be static? > drm/tilcdc/tilcdc_drv.c:78:5: warning: symbol 'tilcdc_atomic_check' was not > declared. Should it be static? > > Cc: Jyri Sarha <jsarha at ti.com> > Cc: Tomi Valkeinen <tomi.valkeinen at ti.com> > Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Thanks, But I have picked already picked these two patches: https://lists.freedesktop.org/archives/dri-devel/2016-September/117900.html http://www.spinics.net/lists/kernel/msg2340400.html I think, I'll send anothet pull request still to nininght to avoid more fixes being generated :). Best regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++-- > drivers/gpu/drm/tilcdc/tilcdc_panel.c | 3 ++- > drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 3 ++- > 3 files changed, 6 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > index f8892e9ad169..d6f8780e41df 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c > @@ -75,8 +75,8 @@ static void tilcdc_fb_output_poll_changed(struct drm_device > *dev) > drm_fbdev_cma_hotplug_event(priv->fbdev); > } > > -int tilcdc_atomic_check(struct drm_device *dev, > - struct drm_atomic_state *state) > +static int tilcdc_atomic_check(struct drm_device *dev, > + struct drm_atomic_state *state) > { > int ret; > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > index 7b3650901930..b8dbcc2a4b7c 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c > @@ -25,6 +25,7 @@ > #include <drm/drm_atomic_helper.h> > > #include "tilcdc_drv.h" > +#include "tilcdc_panel.h" > > struct panel_module { > struct tilcdc_module base; > @@ -433,7 +434,7 @@ static struct of_device_id panel_of_match[] = { > { }, > }; > > -struct platform_driver panel_driver = { > +static struct platform_driver panel_driver = { > .probe = panel_probe, > .remove = panel_remove, > .driver = { > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > index c6a70da6473d..2247150f326a 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c > @@ -23,6 +23,7 @@ > #include <drm/drm_atomic_helper.h> > > #include "tilcdc_drv.h" > +#include "tilcdc_tfp410.h" > > struct tfp410_module { > struct tilcdc_module base; > @@ -382,7 +383,7 @@ static struct of_device_id tfp410_of_match[] = { > { }, > }; > > -struct platform_driver tfp410_driver = { > +static struct platform_driver tfp410_driver = { > .probe = tfp410_probe, > .remove = tfp410_remove, > .driver = { >
