On Wed, Mar 22, 2017 at 09:36:11AM +0100, Daniel Vetter wrote: > The core code doesn't care at all about this, it's entirely dead. > > Cc: Mario Kleiner <mario.klei...@tuebingen.mpg.de> > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > --- > drivers/gpu/drm/drm_irq.c | 8 -------- > include/drm/drmP.h | 1 - > 2 files changed, 9 deletions(-) > > diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c > index 53a526c7b24d..4b0c7475ed13 100644 > --- a/drivers/gpu/drm/drm_irq.c > +++ b/drivers/gpu/drm/drm_irq.c > @@ -810,14 +810,6 @@ int drm_calc_vbltimestamp_from_scanoutpos(struct > drm_device *dev, > /* Return upper bound of timestamp precision error. */ > *max_error = duration_ns; > > - /* Check if in vblank area: > - * vpos is >=0 in video scanout area, but negative > - * within vblank area, counting down the number of lines until > - * start of scanout. > - */ > - if (vbl_status & DRM_SCANOUTPOS_IN_VBLANK) > - ret |= DRM_VBLANKTIME_IN_VBLANK; > -
Indeed nothing seems to look at it. And dropping it shouldn't change anything as we still always set the other bit, so the 'ret > 0' check in the caller should still work correctly. Reviewed-by: Ville Syrjälä <ville.syrj...@linux.intel.com> > /* Convert scanout position into elapsed time at raw_time query > * since start of scanout at first display scanline. delta_ns > * can be negative if start of scanout hasn't happened yet. > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 248d2408e56b..27ecfcdbf752 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -323,7 +323,6 @@ struct pci_controller; > /* Flags and return codes for get_vblank_timestamp() driver function. */ > #define DRM_CALLED_FROM_VBLIRQ 1 > #define DRM_VBLANKTIME_SCANOUTPOS_METHOD (1 << 0) > -#define DRM_VBLANKTIME_IN_VBLANK (1 << 1) > > /* get_scanout_position() return flags */ > #define DRM_SCANOUTPOS_VALID (1 << 0) > -- > 2.11.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Ville Syrjälä Intel OTC _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
