Hi Noralf, Small drive-by comment, noticed while going through my morning coffee. By no means a full review.
On 2 June 2017 at 12:49, Noralf Trønnes <[email protected]> wrote: > +/* pixels on display are numbered from 1 */ > +static void repaper_all_pixels(struct repaper_epd *epd, u8 **pp, > + const u8 *data, u8 fixed_value, const u8 *mask, > + enum repaper_stage stage) > +{ > + unsigned int b; > + > + for (b = epd->width / 8; b > 0; b--) { > + if (data) { > + u16 pixels = repaper_interleave_bits(data[b - 1]); > + u16 pixel_mask = 0xffff; > + > + if (mask) { > + u16 pixel_mask = > repaper_interleave_bits(mask[b - 1]); > + > + pixel_mask = (pixel_mask ^ pixels) & 0x5555; > + pixel_mask |= pixel_mask << 1; The second u16 pixel_mask seems very suspicious - likely a copy/paste mistake ? -Emil _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
