Commit c0c0d9eeeb8d ("drm/msm: hdmi audio support") uses logical
OR operators to build up a value to be written in the
REG_HDMI_AUDIO_INFO0 and REG_HDMI_AUDIO_INFO1 registers when it
should have used bitwise operators.

Signed-off-by: Liviu Dudau <liviu.du...@arm.com>
Fixes: c0c0d9eeeb8d ("drm/msm: hdmi audio support")
---
 drivers/gpu/drm/msm/hdmi/hdmi_audio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c 
b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
index 8177e8511afd..9c34b91ae329 100644
--- a/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
+++ b/drivers/gpu/drm/msm/hdmi/hdmi_audio.c
@@ -175,10 +175,10 @@ int msm_hdmi_audio_update(struct hdmi *hdmi)
                /* configure infoframe: */
                hdmi_audio_infoframe_pack(info, buf, sizeof(buf));
                hdmi_write(hdmi, REG_HDMI_AUDIO_INFO0,
-                               (buf[3] <<  0) || (buf[4] <<  8) ||
-                               (buf[5] << 16) || (buf[6] << 24));
+                               (buf[3] <<  0) | (buf[4] <<  8) |
+                               (buf[5] << 16) | (buf[6] << 24));
                hdmi_write(hdmi, REG_HDMI_AUDIO_INFO1,
-                               (buf[7] <<  0) || (buf[8] << 8));
+                               (buf[7] <<  0) | (buf[8] << 8));
 
                hdmi_write(hdmi, REG_HDMI_GC, 0);
 
-- 
2.13.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to