On Thu, Nov 23, 2017 at 09:04:51PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrj...@linux.intel.com>
>
> Use drm_mode_get_hv_timing() to fill out the plane clip rectangle.
>
> Note that this replaces crtc_state->adjusted_mode usage with
> crtc_state->mode. The latter is the correct choice since that's the
> mode the user provided and it matches the plane crtc coordinates
> the user also provided.
>
> Once everyone agrees on this we can move the clip handling into
> drm_atomic_helper_check_plane_state().
>
> Cc: Laurent Pinchart <laurent.pinch...@ideasonboard.com>
> Cc: Liviu Dudau <liviu.du...@arm.com>
> Cc: Brian Starkey <brian.star...@arm.com>
> Cc: Mali DP Maintainers <mal...@foss.arm.com>
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Acked-by: Liviu Dudau <liviu.du...@arm.com>
Please let me know if you need me to pull this patch into the mali-dp tree.
Best regards,
Liviu
> ---
> drivers/gpu/drm/arm/malidp_planes.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/arm/malidp_planes.c
> b/drivers/gpu/drm/arm/malidp_planes.c
> index 72a07950167e..2f6d608d6eaf 100644
> --- a/drivers/gpu/drm/arm/malidp_planes.c
> +++ b/drivers/gpu/drm/arm/malidp_planes.c
> @@ -148,8 +148,10 @@ static int malidp_se_check_scaling(struct malidp_plane
> *mp,
> if (!crtc_state)
> return -EINVAL;
>
> - clip.x2 = crtc_state->adjusted_mode.hdisplay;
> - clip.y2 = crtc_state->adjusted_mode.vdisplay;
> + if (crtc_state->enable)
> + drm_mode_get_hv_timing(&crtc_state->mode,
> + &clip.x2, &clip.y2);
> +
> ret = drm_atomic_helper_check_plane_state(state, crtc_state, &clip,
> 0, INT_MAX, true, true);
> if (ret)
> --
> 2.13.6
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
