On Wed, Jan 17, 2018 at 04:32:18PM +0200, Laurent Pinchart wrote:
> The connector .dpms operation is only used by the legacy helpers. The
> arc driver being fully atomic, the operation isn't needed anymore.
> Remove it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

Reviewed-by: Daniel Vetter <daniel.vet...@ffwll.ch>

Note that before

commit 144a7999d6334be5237d5926ab19c56bc24d0204
Author: Daniel Vetter <daniel.vet...@ffwll.ch>
Date:   Tue Jul 25 14:02:04 2017 +0200

    drm: Handle properties in the core for atomic drivers

this was necessary. I guess I missed this one here because it was using
the wrong callback.
-Daniel

> ---
>  drivers/gpu/drm/arc/arcpgu_sim.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/arc/arcpgu_sim.c 
> b/drivers/gpu/drm/arc/arcpgu_sim.c
> index bca3a678c955..1d4d5dd7e763 100644
> --- a/drivers/gpu/drm/arc/arcpgu_sim.c
> +++ b/drivers/gpu/drm/arc/arcpgu_sim.c
> @@ -53,7 +53,6 @@ arcpgu_drm_connector_helper_funcs = {
>  };
>  
>  static const struct drm_connector_funcs arcpgu_drm_connector_funcs = {
> -     .dpms = drm_helper_connector_dpms,
>       .reset = drm_atomic_helper_connector_reset,
>       .fill_modes = drm_helper_probe_single_connector_modes,
>       .destroy = arcpgu_drm_connector_destroy,
> -- 
> Regards,
> 
> Laurent Pinchart
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to