On 2018-01-29 05:55 PM, Alex Deucher wrote: > On Mon, Jan 29, 2018 at 5:35 PM, <sylvain.bertr...@gmail.com> wrote: >> On Mon, Jan 29, 2018 at 03:40:34PM -0500, Alex Deucher wrote: >>> On Mon, Jan 29, 2018 at 3:34 PM, <sylvain.bertr...@gmail.com> wrote: >>>> As far as I can remember, not for the new features ofc, DCE programming >>>> for GCN1 >>>> is very similar if not mostly the same than DCE programming for GCN1.1/2 >>>> which >>>> is supported by the new DC code. >>>> >>>> Is this planned? >>> >>> Right, as I said, you could definitely leverage the support for DCE8 >>> in DC. The blocks are very similar. At the moment, we have no plans >>> to implement DC support for DCE6. >> >> Ok. >> >> Which git repo/branch has the most up-to-date DCE code? > > https://cgit.freedesktop.org/~agd5f/linux/log/?h=amd-staging-drm-next > >> >> Is there a fine granularity selection system for supported DCE features? That >> to expose the available/implemented DCE features to userland DRM (I can test >> only discret >> tahiti XT code paths). >> >> I'll try to get something working. > > amdgpu only supports SI and newer parts so you don't have to worry > about DCE6-based APUs in this case. The current DCE8, 10, and 11 > implementations share a lot of code. Your best bet would be to follow > a similar model for DCE6. >
A good start would be to try re-using the DCE8 code for DCE6. You can probably create a new dce60_resource.c and dce60_hw_sequencer.c, copying the register structs, caps, function pointers, constructors and destructors from the dce80_ versions. Then add a new dce_version and hook it up all over the place, add the CHIP IDs for DC support in amdgpu_device_asic_has_dc_support and you should pretty much be good to go. If you're lucky you'll light up. If not you'll have to debug. As Alex mentioned, implementing DC support SI parts are not a priority for us, but if you have a working patchset I'll be happy to review. Harry > Alex > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
