Hi Maciej,

On 19/02/18 15:43, Maciej Purski wrote:
When a driver is going to use clk_bulk_get() function, it has to
initialize an array of clk_bulk_data, by filling its id fields.

Add a new function to the core, which dynamically allocates
clk_bulk_data array and fills its id fields. Add clk_bulk_free()
function, which frees the array allocated by clk_bulk_alloc() function.
Add a managed version of clk_bulk_alloc().

Seeing how every subsequent patch ends up with the roughly this same stanza:

        x = devm_clk_bulk_alloc(dev, num, names);
        if (IS_ERR(x)
                return PTR_ERR(x);
        ret = devm_clk_bulk_get(dev, x, num);

I wonder if it might be better to simply implement:

        int devm_clk_bulk_alloc_get(dev, &x, num, names)

that does the whole lot in one go, and let drivers that want to do more fiddly things continue to open-code the allocation.

But perhaps that's an abstraction too far... I'm not all that familiar with the lie of the land here.

Signed-off-by: Maciej Purski <m.pur...@samsung.com>
  drivers/clk/clk-bulk.c   | 16 ++++++++++++
  drivers/clk/clk-devres.c | 37 +++++++++++++++++++++++++---
  include/linux/clk.h      | 64 ++++++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 113 insertions(+), 4 deletions(-)

@@ -598,6 +645,23 @@ struct clk *clk_get_sys(const char *dev_id, const char 
#else /* !CONFIG_HAVE_CLK */ +static inline struct clk_bulk_data *clk_bulk_alloc(int num_clks,
+                                                  const char **clk_ids)
+       return NULL;

Either way, is it intentional not returning an ERR_PTR() value in this case? Since NULL will pass an IS_ERR() check, it seems a bit fragile for an allocation call to apparently succeed when the whole API is configured out (and I believe introducing new uses of IS_ERR_OR_NULL() is in general strongly discouraged.)


+static inline struct clk_bulk_data *devm_clk_bulk_alloc(struct device *dev,
+                                                       int num_clks,
+                                                       const char **clk_ids)
+       return NULL;
+static inline void clk_bulk_free(struct clk_bulk_data *clks)
  static inline struct clk *clk_get(struct device *dev, const char *id)
        return NULL;

dri-devel mailing list

Reply via email to