>-----Original Message-----
>From: Ville Syrjala [mailto:ville.syrj...@linux.intel.com]
>Sent: Friday, February 23, 2018 3:12 AM
>To: intel-...@lists.freedesktop.org
>Cc: dri-devel@lists.freedesktop.org; Mihail Atanassov
><mihail.atanas...@arm.com>; Liviu Dudau <liviu.du...@arm.com>; Brian
>Starkey <brian.star...@arm.com>; Mali DP Maintainers
><mal...@foss.arm.com>; Lin, Johnson <johnson....@intel.com>; Shankar, Uma
><uma.shan...@intel.com>; Sharma, Shashank <shashank.sha...@intel.com>
>Subject: [PATCH 1/4] drm/uapi: The ctm matrix uses sign-magnitude
>representation
>
>From: Ville Syrjälä <ville.syrj...@linux.intel.com>
>
>The documentation for the ctm matrix suggests a two's complement format, but
>at least the i915 implementation is using sign-magnitude instead. And looks
>like
>malidp is doing the same. Change the docs to match the current implementation,
>and change the type from __s64 to __u64 to drive the point home.
>
Looks ok to me.
Reviewed-by: Uma Shankar <uma.shan...@intel.com>
>Cc: dri-devel@lists.freedesktop.org
>Cc: Mihail Atanassov <mihail.atanas...@arm.com>
>Cc: Liviu Dudau <liviu.du...@arm.com>
>Cc: Brian Starkey <brian.star...@arm.com>
>Cc: Mali DP Maintainers <mal...@foss.arm.com>
>Cc: Johnson Lin <johnson....@intel.com>
>Cc: Uma Shankar <uma.shan...@intel.com>
>Cc: Shashank Sharma <shashank.sha...@intel.com>
>Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
>---
> include/uapi/drm/drm_mode.h | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
>diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h
>index 2c575794fb52..b5d7d9e0eff5 100644
>--- a/include/uapi/drm/drm_mode.h
>+++ b/include/uapi/drm/drm_mode.h
>@@ -598,8 +598,11 @@ struct drm_mode_crtc_lut { };
>
> struct drm_color_ctm {
>- /* Conversion matrix in S31.32 format. */
>- __s64 matrix[9];
>+ /*
>+ * Conversion matrix in S31.32 sign-magnitude
>+ * (not two's complement!) format.
>+ */
>+ __u64 matrix[9];
> };
>
> struct drm_color_lut {
>--
>2.16.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
