On 29/03/18 15:31, Sebastian Reichel wrote: > Hi, > > On Thu, Mar 29, 2018 at 12:00:18PM +0100, Emil Velikov wrote: >> On 29 March 2018 at 11:40, Tomi Valkeinen <tomi.valkei...@ti.com> wrote: >>> omap_framebuffer_get_next_connector() is not used, remove it. >>> >> Seems to have been unused for a few years now. >> Namely since commit 5a35876e2830511cb8110667fc426c6a6165a593 >> >> Reviewed-by: Emil Velikov <emil.veli...@collabora.com> > > I have a pending patch using that function to basically restore the > functionality from the referenced commit:
Oh, ok. I'll drop this patch. These was a Klocwork warning for this function, so the easiest fix was to remove it. drivers/gpu/drm/omapdrm/omap_fb.c:326 INFINITE_LOOP.LOCAL (2:Error) Analyze Infinite loop * omap_fb.c:326: Entering loop with precondition (from!=0) && (connector!=0) && from == connector * omap_fb.c:326: condition 0 is always false * omap_fb.c:326: condition 0 is always false * omap_fb.c:327: condition connector!=from is always false Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
