Hi Jordan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robclark/msm-next]
[also build test WARNING on next-20180406]
[cannot apply to v4.16]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Jordan-Crouse/drm-msm-GPU-crash-state/20180406-170513
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget 
https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O 
~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function 'adreno_show':
>> drivers/gpu/drm/msm/adreno/adreno_gpu.c:533:31: warning: format '%ld' 
>> expects argument of type 'long int', but argument 3 has type 'size_t {aka 
>> unsigned int}' [-Wformat=]
       drm_printf(p, "    size: %ld\n", state->bos[i].size);
                                ~~^     ~~~~~~~~~~~~~~~~~~
                                %d

vim +533 drivers/gpu/drm/msm/adreno/adreno_gpu.c

   496  
   497  void adreno_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
   498                  struct drm_printer *p)
   499  {
   500          struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
   501          int i;
   502  
   503          if (IS_ERR_OR_NULL(state))
   504                  return;
   505  
   506          drm_printf(p, "revision: %d (%d.%d.%d.%d)\n",
   507                          adreno_gpu->info->revn, adreno_gpu->rev.core,
   508                          adreno_gpu->rev.major, adreno_gpu->rev.minor,
   509                          adreno_gpu->rev.patchid);
   510  
   511          drm_printf(p, "rbbm-status: 0x%08x\n", state->rbbm_status);
   512  
   513          drm_printf(p, "ringbuffer:\n");
   514  
   515          for (i = 0; i < gpu->nr_rings; i++) {
   516                  drm_printf(p, "  - id: %d\n", i);
   517                  drm_printf(p, "    last-fence: %d\n", 
state->ring[i].seqno);
   518                  drm_printf(p, "    retired-fence: %d\n", 
state->ring[i].fence);
   519                  drm_printf(p, "    rptr: %d\n", state->ring[i].rptr);
   520                  drm_printf(p, "    wptr: %d\n", state->ring[i].wptr);
   521                  drm_printf(p, "    size: %d\n", MSM_GPU_RINGBUFFER_SZ);
   522  
   523                  adreno_show_object(p, state->ring[i].data,
   524                          state->ring[i].data_size);
   525          }
   526  
   527          if (state->bos) {
   528                  drm_printf(p, "bos:\n");
   529  
   530                  for (i = 0; i < state->nr_bos; i++) {
   531                          drm_printf(p, "  - iova: 0x%016llx\n",
   532                                  state->bos[i].iova);
 > 533                          drm_printf(p, "    size: %ld\n", 
 > state->bos[i].size);
   534  
   535                          adreno_show_object(p, state->bos[i].data,
   536                                  state->bos[i].size);
   537                  }
   538          }
   539  
   540          drm_printf(p, "registers:\n");
   541          drm_printf(p, "  - [offset, value]\n");
   542  
   543          for (i = 0; i < state->nr_registers; i++) {
   544                  drm_printf(p, "  - [0x%04x, 0x%08x]\n",
   545                          state->registers[i * 2] << 2,
   546                          state->registers[(i * 2) + 1]);
   547          }
   548  }
   549  #endif
   550  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to