On Friday, 2018-10-05 12:07:26 -0400, Harry Wentland wrote: > On 2018-10-04 04:24 PM, Daniel Vetter wrote: > > Motivated by review comments from Ville&Sean. > > > > Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> > > Cc: Sean Paul <s...@poorly.run> > > Signed-off-by: Daniel Vetter <daniel.vet...@intel.com> > > Acked-by: Harry Wentland <harry.wentl...@amd.com> > > Harry > > > --- > > Documentation/gpu/todo.rst | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > > index 77c2b3c25565..5c9d86c962af 100644 > > --- a/Documentation/gpu/todo.rst > > +++ b/Documentation/gpu/todo.rst > > @@ -339,6 +339,16 @@ Some of these date from the very introduction of KMS > > in 2008 ... > > leftovers from older (never merged into upstream) KMS designs where modes > > where set using their ID, including support to add/remove modes. > > > > +- Make ->funcs and ->helper_private vtables optional. There's a bunch of > > empty > > + function tables in drivers, but before we can remove them we need to > > make sure > > + that all the users in helpers and drivers do correctly check for a NULL > > + vtable. > > + > > +- Cleanup up the various ->destroy callbacks. A lot of them just wrapt the
small typo: s/wrapt/wrap/ > > + drm_*_cleanup implementations and can be removed. Some tack a kfree() at > > the > > + end, for which we could add drm_*_cleanup_kfree(). And then there's the > > (for > > + historical reasons) misnamed drm_primary_helper_destroy() function. > > + > > Better Testing > > ============== > > > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
