Hi Linus, On Thu, Oct 18, 2018 at 02:27:42PM +0200, Linus Walleij wrote: > Having failed any attempts at a more generic solution, > I fall back to the very specific solution: define a simple > panel for the ARM RTSMv8 emulated platform.
<Sad face> > > I am doing this so we can convert all old users from the > previous fbdev driver to the PL111 DRM driver. > > This works fine as far as I can test, provided the > device tree for RTSMv8 is augmented accordingly. While this patch looks good to me (you can add my Reviewed-by if you want), I'm surprised to see no other patches for the users of the panel. Is it all in a DTS change? Best regards, Liviu > > Cc: Sudeep Holla <[email protected]> > Cc: Lorenzo Pieralisi <[email protected]> > Cc: Liviu Dudau <[email protected]> > Cc: Mali DP Maintainers <[email protected]> > Cc: Robin Murphy <[email protected]> > Signed-off-by: Linus Walleij <[email protected]> > --- > drivers/gpu/drm/panel/panel-simple.c | 30 ++++++++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c > b/drivers/gpu/drm/panel/panel-simple.c > index 97964f7f2ace..b36fb1db16fb 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -2323,6 +2323,33 @@ static const struct panel_desc winstar_wf35ltiacd = { > .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > }; > > +static const struct drm_display_mode arm_rtsmv8_mode[] = { > + { > + .clock = 65000, > + .hdisplay = 1024, > + .hsync_start = 1024 + 24, > + .hsync_end = 1024 + 24 + 136, > + .htotal = 1024 + 24 + 136 + 160, > + .vdisplay = 768, > + .vsync_start = 768 + 3, > + .vsync_end = 768 + 3 + 6, > + .vtotal = 768 + 3 + 6 + 29, > + .vrefresh = 60, > + .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > + }, > +}; > + > +static const struct panel_desc arm_rtsmv8 = { > + .modes = arm_rtsmv8_mode, > + .num_modes = 1, > + .bpc = 8, > + .size = { > + .width = 400, > + .height = 300, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB888_1X24, > +}; > + > static const struct of_device_id platform_of_match[] = { > { > .compatible = "ampire,am-480272h3tmqw-t01h", > @@ -2330,6 +2357,9 @@ static const struct of_device_id platform_of_match[] = { > }, { > .compatible = "ampire,am800480r3tmqwa1h", > .data = &ire_am800480r3tmqwa1h, > + }, { > + .compatible = "arm,rtsmv8-display", > + .data = &arm_rtsmv8, > }, { > .compatible = "auo,b101aw03", > .data = &auo_b101aw03, > -- > 2.17.2 > -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯ _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
